Walker, thanks for picking up the KIP and reworking it for the changed API.
Overall, the updated API suggestions make sense to me. The seem to align quite nicely with our current API design. One nit: In `CogroupedKStream#aggregate(...)` the type parameter of `Materialized` should be `V`, not `VR`? -Matthias On 10/14/19 2:57 PM, Walker Carlson wrote: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-150+-+Kafka-Streams+Cogroup > here > is a link > > On Mon, Oct 14, 2019 at 2:52 PM Walker Carlson <wcarl...@confluent.io> > wrote: > >> Hello all, >> >> I have picked up and updated KIP-150. Due to changes to the project since >> KIP #150 was written there are a few items that need to be updated. >> >> First item that changed is the adoption of the Materialized parameter. >> >> The second item is the WindowedBy. How the old KIP handles windowing is >> that it overloads the aggregate function to take in a Window object as well >> as the other parameters. The current practice to window grouped-streams is >> to call windowedBy and receive a windowed stream object. The existing >> interface for a windowed stream made from a grouped stream will not work >> for cogrouped streams. Hence, we have to make new interfaces for cogrouped >> windowed streams. >> >> Please take a look, I would like to hear your feedback, >> >> Walker >> >
signature.asc
Description: OpenPGP digital signature
