----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20083/#review39899 -----------------------------------------------------------
core/src/main/scala/kafka/utils/Utils.scala <https://reviews.apache.org/r/20083/#comment72645> Does this work when there are string constants before the first and after the last separator? In this case, separated.length is one more than args.length. - Jun Rao On April 9, 2014, 12:41 p.m., Ivan Lyutov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20083/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 12:41 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1351 > https://issues.apache.org/jira/browse/KAFKA-1351 > > > Repository: kafka > > > Description > ------- > > KAFKA-1351 - removed redundant changes. > > > KAFKA-1351 - Replaced String.format occurencies with Utils.formatString > > > KAFKA-1351 - Implemented more efficient substitution for String.format in > Scala. > > > Diffs > ----- > > core/src/main/scala/kafka/Kafka.scala > 988014a51c332ba04609ee7fbb06f0b09546f267 > core/src/main/scala/kafka/admin/AdminUtils.scala > 36ddeb44490e8343a4e8056c45726ac660e4b2f9 > core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala > 9b3c6aeaf77db6cea75272c60a42fa45955fed5b > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala > 2637586af99cf8a6c4ea3a4ccb244d1e76f0f81a > core/src/main/scala/kafka/admin/ShutdownBroker.scala > 2dd47e7362f42b434ec8bb6b93f0cb0cb1a50a28 > core/src/main/scala/kafka/admin/TopicCommand.scala > 686a0dfc65b036263375db7f64f1f2bae42199b0 > core/src/main/scala/kafka/api/FetchResponse.scala > d117f10f724b09d6deef0df3a138d28fc91aa13a > core/src/main/scala/kafka/api/RequestKeys.scala > fbfc9d3aeaffed4ca85902125fcc1050086835db > core/src/main/scala/kafka/api/StopReplicaRequest.scala > 68fc1389ee71122adb716d9d821dd8987a78ecee > core/src/main/scala/kafka/api/TopicMetadata.scala > 0513a59ed94e556894b3515dc38666ee9a66ae3d > core/src/main/scala/kafka/client/ClientUtils.scala > fc9e08423a4127e1d64be1e62def567ea9eb80a3 > core/src/main/scala/kafka/cluster/Broker.scala > 9407ed21fbbd57edeecd888edc32bea6a05d95b3 > core/src/main/scala/kafka/cluster/Partition.scala > 6d6b4ab91608162201d2737d784580728193566a > core/src/main/scala/kafka/common/ClientIdAndBroker.scala > 93223a9c93b55df85e7f28d1c8667c9a0a8c8992 > core/src/main/scala/kafka/common/ClientIdAndTopic.scala > 7acf9e76bdd874953fb49bf0673232b64afbf008 > core/src/main/scala/kafka/common/OffsetMetadataAndError.scala > 1586243d20d6a181a1bd9f07e1c9493596005b32 > core/src/main/scala/kafka/common/TopicAndPartition.scala > df3db912f5daef6a25b4b2dd2220d2cc3795bce6 > core/src/main/scala/kafka/consumer/ConsoleConsumer.scala > 0f62819be0562f62c0f778bd20ead053f01a6f2f > core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala > b9e2bea7b442a19bcebd1b350d39541a8c9dd068 > core/src/main/scala/kafka/consumer/ConsumerIterator.scala > ac491b4da2583ef7227c67f5b8bc0fd731d705c3 > core/src/main/scala/kafka/consumer/PartitionTopicInfo.scala > 9c779ce072fb0a3426e96fd77f383cce6991a0f9 > core/src/main/scala/kafka/consumer/SimpleConsumer.scala > 0e64632210385ef63c2ad3445b55ac4f37a63df2 > core/src/main/scala/kafka/consumer/TopicFilter.scala > 5a13540699be45de8fd3a6805820b5866ff9b7fa > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > ff5e81943e10ef37de16f657aeecc25e17d3e83a > core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala > 38f4ec0bd1b388cc8fc04b38bbb2e7aaa1c3f43b > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > f17d97603798e803d035f313f0165f11f6d0f2c0 > core/src/main/scala/kafka/controller/KafkaController.scala > fcabd0da201ccd478f5884bcca9b75a8c8ea8373 > core/src/main/scala/kafka/controller/PartitionLeaderSelector.scala > d3b25fa405e9fe467bcedaa290784d75692e7207 > core/src/main/scala/kafka/controller/PartitionStateMachine.scala > 6457b56340a1b5440b07612f69dcffe4b051f919 > core/src/main/scala/kafka/controller/ReplicaStateMachine.scala > 0e47dac8cbf65a86d053a3371a18af467afd70ae > core/src/main/scala/kafka/controller/TopicDeletionManager.scala > 09f54acc733d49a9be9a9c6633271c190dea1bf0 > core/src/main/scala/kafka/javaapi/TopicMetadataRequest.scala > 7e6da164a26b1893c26c624a9998d4fedf8af95e > core/src/main/scala/kafka/log/FileMessageSet.scala > b2652ddbe2f857028d5980e29a008b2c614694a3 > core/src/main/scala/kafka/log/Log.scala > 46df8d99d977a3b010a9b9f4698187fa9bfb2498 > core/src/main/scala/kafka/log/LogCleaner.scala > b9ffe00d6c656476ed4c4e6f68fb2ba115090c92 > core/src/main/scala/kafka/log/LogCleanerManager.scala > 6a981345fd7dc711e6c4f058a42bd7f8f9d350fe > core/src/main/scala/kafka/log/LogConfig.scala > 5746ad4767589594f904aa085131dd95e56d72bb > core/src/main/scala/kafka/log/LogManager.scala > 8ed9b68e763aa14e3ef282eec738fa190eb20132 > core/src/main/scala/kafka/log/LogSegment.scala > 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8 > core/src/main/scala/kafka/log/OffsetIndex.scala > 8a62dfad9bc48b2a295697400d4ebfd2f6806a9f > core/src/main/scala/kafka/message/CompressionCodec.scala > 8762a790af2ab7f60a5e4e19955c7eb7ad7bc749 > core/src/main/scala/kafka/message/Message.scala > 52c082f5213ba48a39bf0d17e4ced2714276f0e0 > core/src/main/scala/kafka/metrics/KafkaCSVMetricsReporter.scala > ea9559f822c1120e1997916190fcd597328e4965 > core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala > a44254564531a3fc6008da2be6c1df8bdb75ec75 > core/src/main/scala/kafka/network/RequestChannel.scala > a6ec970d72fc8adc56bc6e200d1ff5bbf0d2b748 > core/src/main/scala/kafka/network/SocketServer.scala > dcfca3f4156957b0006ba9bfdeca848c115825a8 > core/src/main/scala/kafka/producer/BrokerPartitionInfo.scala > 13a8aa665016e19284c8ced35bac2195fe9e4378 > core/src/main/scala/kafka/producer/ProducerPool.scala > 43df70bb461dd3e385e6b20396adef3c4016a3fc > core/src/main/scala/kafka/producer/SyncProducer.scala > 489f0077512d9a69be81649c490274964290fa40 > core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala > d8ac915de31a26d7aa67760d69373975cacd0c9d > core/src/main/scala/kafka/server/AbstractFetcherManager.scala > 9390edf37dae9815d4a3790fdd31dac422382698 > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > db7017b8a8ff06384674f36792053e4bc68419f1 > core/src/main/scala/kafka/server/KafkaApis.scala > c068ef69207c351eec413a595f1747c59f8b3983 > core/src/main/scala/kafka/server/KafkaHealthcheck.scala > 4acdd70fe9c1ee78d6510741006c2ece65450671 > core/src/main/scala/kafka/server/KafkaRequestHandler.scala > 871212bf9110ca95ca7d2109be070f69d0f90247 > core/src/main/scala/kafka/server/KafkaServer.scala > c208f83bed7fb91f07fae42f2b66892e6d46fecc > core/src/main/scala/kafka/server/OffsetCheckpoint.scala > 19f61a9718a7f8e6f9bf743ac9eb2118d0fdd9b0 > core/src/main/scala/kafka/server/OffsetManager.scala > 89a88a7e4055f804429b64e85b2f65312d1e2155 > core/src/main/scala/kafka/server/ReplicaFetcherManager.scala > 351dbbad3bdb709937943b336a5b0a9e0162a5e2 > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala > 75ae1e161769a020a102009df416009bd6710f4a > core/src/main/scala/kafka/server/ReplicaManager.scala > 0f5aaa9888d6c0ca0b073f4742bee14ad72d0484 > core/src/main/scala/kafka/server/RequestPurgatory.scala > c064c5c4cf1191335572da8a2caf5f95dce902c1 > core/src/main/scala/kafka/server/TopicConfigManager.scala > d41fd33d91406dfa2ce8c1e1b04a078e983ccadd > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala > e5b6ff1e2544b043007cf16a6b9dd4451c839e63 > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala > 88f824fa5afe7964efc569bc0732fd40a55c5c93 > core/src/main/scala/kafka/tools/DumpLogSegments.scala > f0ab02a4e6dd1b945b263607c26ae22f00e6b158 > core/src/main/scala/kafka/tools/ExportZkOffsets.scala > 005231f38dd9cea60ec953a28a1ab57d3e316eed > core/src/main/scala/kafka/tools/GetOffsetShell.scala > fba652e3716a67b04431fc46790ad255201b639f > core/src/main/scala/kafka/tools/ImportZkOffsets.scala > c8023ee60c07b6e59906da9331bd5d764fd60cba > core/src/main/scala/kafka/tools/MirrorMaker.scala > e4d1a86f673f7df7fe71ce44e3550fcde8d01bba > core/src/main/scala/kafka/tools/SimpleConsumerShell.scala > 747e07280cce72d621acbc771337b909a9b2487e > core/src/main/scala/kafka/tools/TestLogCleaning.scala > edb6e5f8fe511debd8b971dddb786e684ed7e1ac > core/src/main/scala/kafka/tools/UpdateOffsetsInZK.scala > 111c9a8b94ce45d95551482e9fd3f8c1cccbf548 > core/src/main/scala/kafka/tools/VerifyConsumerRebalance.scala > 92c0d1f979fba3496d1f092cc073073dcf4447e6 > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala > a969a22c6b82ed5c9f053a50594b1c7a768efd0e > core/src/main/scala/kafka/utils/Json.scala > d1102844748f2e88f79932281fe95583a57d2d16 > core/src/main/scala/kafka/utils/KafkaScheduler.scala > 8e3750506c1803f34b9f1829b21097f1441d7463 > core/src/main/scala/kafka/utils/Log4jController.scala > a015c8109f050cabdea988f2215bd01ec0d8573a > core/src/main/scala/kafka/utils/Throttler.scala > d1a144d7882919426824799ff8e8a47f89c83158 > core/src/main/scala/kafka/utils/Utils.scala > 6bfbac16e2f8d68b8c711a0336c698aa6f610ae8 > core/src/main/scala/kafka/utils/VerifiableProperties.scala > d40b03ca844ebb3e4f91e8bc44bc5edcf4cb292c > core/src/main/scala/kafka/utils/ZkUtils.scala > 16bf7e3e87b520b31485199b2830494ca5f96c1a > core/src/test/scala/unit/kafka/utils/UtilsTest.scala > 920f318c85a747b689f97c0e73e4234f20b1460a > > Diff: https://reviews.apache.org/r/20083/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Lyutov > >
