> On April 9, 2014, 1:23 a.m., Jun Rao wrote: > > Thanks for the patch. Do you have any performance numbers?
Sure, It showed ~37% perfomance gain on 10000 Operations. See testFormatStringPerformance for details. - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20083/#review39852 ----------------------------------------------------------- On April 7, 2014, 3:02 p.m., Ivan Lyutov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20083/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 3:02 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1351 > https://issues.apache.org/jira/browse/KAFKA-1351 > > > Repository: kafka > > > Description > ------- > > KAFKA-1351 - Implemented more efficient substitution for String.format in > Scala. > > > Diffs > ----- > > core/src/main/scala/kafka/utils/Utils.scala > 6bfbac16e2f8d68b8c711a0336c698aa6f610ae8 > core/src/test/scala/unit/kafka/utils/UtilsTest.scala > 920f318c85a747b689f97c0e73e4234f20b1460a > > Diff: https://reviews.apache.org/r/20083/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Lyutov > >
