-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20131/
-----------------------------------------------------------
(Updated April 8, 2014, 11:31 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Fix KAFKA-1353: incorporate Jun's comment round three
Bugs: KAFKA-1353
https://issues.apache.org/jira/browse/KAFKA-1353
Repository: kafka
Description (updated)
-------
KAFKA-1353.v4
Remove unused imports
KAFKA-1353.v3
KAFKA-1353.v2
KAFKA-1353.v1
Diffs (updated)
-----
core/src/main/scala/kafka/network/RequestChannel.scala
a6ec970d72fc8adc56bc6e200d1ff5bbf0d2b748
core/src/main/scala/kafka/network/SocketServer.scala
dcfca3f4156957b0006ba9bfdeca848c115825a8
core/src/main/scala/kafka/server/KafkaConfig.scala
b0506d4881176cd95914847c4275e428a8d2ca10
core/src/main/scala/kafka/server/KafkaRequestHandler.scala
871212bf9110ca95ca7d2109be070f69d0f90247
Diff: https://reviews.apache.org/r/20131/diff/
Testing
-------
Local test with 9 new producer performance and one handler thread: in 3
minutes, the io threads idle time drops to 10%, but after that remains
vibrating, the network threads keeps dropping but much slower, only to about
85% in 3 minutes.
Adding to 15 producers, the io thread starts to drop again, until close to 2%
where it starts vibrating again, whereas the network threads drops to about 80%.
Thanks,
Guozhang Wang
