----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20131/#review39831 -----------------------------------------------------------
core/src/main/scala/kafka/network/SocketServer.scala <https://reviews.apache.org/r/20131/#comment72514> How about using the following comment? We use a single meter for aggregate idle percentage for the thread pool. Since meter is calculated as total_recorded_value / time_window and time_window is independent of the number of threads, each recorded idle time should be discounted by # threads. core/src/main/scala/kafka/server/KafkaRequestHandler.scala <https://reviews.apache.org/r/20131/#comment72506> Perhaps use totalHandlerThreads? - Jun Rao On April 8, 2014, 9:56 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20131/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 9:56 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1353 > https://issues.apache.org/jira/browse/KAFKA-1353 > > > Repository: kafka > > > Description > ------- > > Remove unused imports > > > KAFKA-1353.v3 > > > KAFKA-1353.v2 > > > KAFKA-1353.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/network/RequestChannel.scala > a6ec970d72fc8adc56bc6e200d1ff5bbf0d2b748 > core/src/main/scala/kafka/network/SocketServer.scala > dcfca3f4156957b0006ba9bfdeca848c115825a8 > core/src/main/scala/kafka/server/KafkaRequestHandler.scala > 871212bf9110ca95ca7d2109be070f69d0f90247 > > Diff: https://reviews.apache.org/r/20131/diff/ > > > Testing > ------- > > Local test with 9 new producer performance and one handler thread: in 3 > minutes, the io threads idle time drops to 10%, but after that remains > vibrating, the network threads keeps dropping but much slower, only to about > 85% in 3 minutes. > > Adding to 15 producers, the io thread starts to drop again, until close to 2% > where it starts vibrating again, whereas the network threads drops to about > 80%. > > > Thanks, > > Guozhang Wang > >
