> On Jan. 23, 2014, 5:51 p.m., John Fung wrote: > > There will be only 1 producer_performance running per entity_id. Therefore, > > entity_id can be used as a key in the dictionary to keep track of multiple > > running producer_performance threads: > > > > + os.tcaseEnv.producerHostParentPidDict[entityId] = os.getpid() > > Guozhang Wang wrote: > Hi John, thanks for the comments. Not sure I get it clear though. What do > you suggest to change the above line?
Guozhang, sorry about the confusion. I meant using entityId as a key to the dictionary is the proper way to track producer pids. I wanted to give a "+1" for it. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17006/#review32632 ----------------------------------------------------------- On Jan. 22, 2014, 7:51 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17006/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 7:51 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1212 > https://issues.apache.org/jira/browse/KAFKA-1212 > > > Repository: kafka > > > Description > ------- > > KAFKA-1212.v2 > > > Diffs > ----- > > system_test/utils/kafka_system_test_utils.py > fb4a9c05bf6f39a7abf41126325ed5ca26bcc246 > > Diff: https://reviews.apache.org/r/17006/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
