----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/#review32002 -----------------------------------------------------------
Looks good. Just a couple of minor comments. core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/16360/#comment60751> Should controllerId be logged using %d? core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/16360/#comment60752> Since this foreach is not a liner, it's probably better to use {, instead of (? - Jun Rao On Jan. 16, 2014, 12:43 a.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16360/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 12:43 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1188 > https://issues.apache.org/jira/browse/KAFKA-1188 > > > Repository: kafka > > > Description > ------- > > KAFKA-1188.v5 > > > Dummy > > > KAFKA-1188.v4 > > > KAFKA-1188.v3 > > > KAFKA-1118.v2 > > > KAFKA-1188.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 1087a2e91c86e36a2494a95913a3ec2daf238287 > core/src/main/scala/kafka/server/ReplicaManager.scala > f9d10d385cee49a1e3be8c82e3ffa22ef87a8fd6 > > Diff: https://reviews.apache.org/r/16360/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
