[
https://issues.apache.org/jira/browse/KAFKA-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765633#comment-13765633
]
Jun Rao commented on KAFKA-998:
-------------------------------
Thanks for the patch. Looks good overall. Just one comment:
10. ErrorMapping.fatalException(): Should we rename it to
unrecoverableException? MessageSizeTooLarge doesn't seems like a fatal
exception.
I am not sure if it's worth patching this in 0.8. The workaround is to reduce
the batch size, as well reducing retry times and retry intervals.
> Producer should not retry on non-recoverable error codes
> --------------------------------------------------------
>
> Key: KAFKA-998
> URL: https://issues.apache.org/jira/browse/KAFKA-998
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8, 0.8.1
> Reporter: Joel Koshy
> Assignee: Guozhang Wang
> Attachments: KAFKA-998.v1.patch
>
>
> Based on a discussion with Guozhang. The producer currently retries on all
> error codes (including messagesizetoolarge which is pointless to retry on).
> This can slow down the producer unnecessarily.
> If at all we want to retry on that error code we would need to retry with a
> smaller batch size, but that's a separate discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
