[
https://issues.apache.org/jira/browse/KAFKA-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13759257#comment-13759257
]
Joel Koshy commented on KAFKA-998:
----------------------------------
Oh I thought this was for 0.8 - it does apply on trunk. Do people think this
is small and important enough to apply to 0.8?
Another comment after thinking about
the patch: in dispatchSerializedData - would it be better to just drop data
that have hit the message size limit? That way, there is no need to return the
needRetry, so the dispatchSerializedData signature remains the same. The
disadvantage is that we won't propagage a failedtosendmessage exception for
such messages to the caller - for the producer in async mode that is probably
fine (since right now the caller can't really do much with that exception) - in
sync mode the caller could perhaps decide to send fewer messages at once. Even
in that case we don't really say which topics/messages hit the message size
limit so I think it is fine in that case as well. Furthermore, this would be
covered by KAFKA-1026 to a large degree.
> Producer should not retry on non-recoverable error codes
> --------------------------------------------------------
>
> Key: KAFKA-998
> URL: https://issues.apache.org/jira/browse/KAFKA-998
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8, 0.8.1
> Reporter: Joel Koshy
> Assignee: Guozhang Wang
> Attachments: KAFKA-998.v1.patch
>
>
> Based on a discussion with Guozhang. The producer currently retries on all
> error codes (including messagesizetoolarge which is pointless to retry on).
> This can slow down the producer unnecessarily.
> If at all we want to retry on that error code we would need to retry with a
> smaller batch size, but that's a separate discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
