[
https://issues.apache.org/jira/browse/KAFKA-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585201#comment-13585201
]
Jun Rao commented on KAFKA-734:
-------------------------------
Thanks for patch v5. Just some minor comments. Once they are addressed, the
patch can be checked in.
50. KafkaMigrationTool:
50.1 Should client.id for producer be set to the client.id in the producer
property + the producer thread id?
50.2 In the shutdown hook, we need to call consumerConnector_07.shutdown first.
50.3 In MigrationThread, we don't need isRunning since it's never used.
50.4 In the catch clause of main(), it's probably better to print out the error
and stacktrace, in addition to the logging in log4j. This way, if people forget
to set log4j properly, they can still see why the tool failed.
50.5 At the end of shutdown hook, it's probably useful to print out sth like
"migration tool shuts down successfully".
> Migration tool needs a revamp, it was poorly written and has many performance
> bugs
> ----------------------------------------------------------------------------------
>
> Key: KAFKA-734
> URL: https://issues.apache.org/jira/browse/KAFKA-734
> Project: Kafka
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Neha Narkhede
> Priority: Blocker
> Labels: p1
> Attachments: kafka-734-v1.patch, kafka-734-v2.patch,
> kafka-734-v3.patch, kafka-734-v4.patch, kafka-734-v5.patch
>
>
> Migration tool has a number of problems ranging from poor logging to poor
> design. This needs to be thought through again
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
