[ 
https://issues.apache.org/jira/browse/KAFKA-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564995#comment-13564995
 ] 

Jun Rao commented on KAFKA-734:
-------------------------------

Thanks for the patch. Some comments:

1. Utils.partition(): It's probably better to move this method to MigrationTool 
since it's customized for its use case. Also, it would be great if we can add 
some examples of how this method works.

2. Producer: asyncProducerID is no longer used.
                
> Migration tool needs a revamp, it was poorly written and has many performance 
> bugs
> ----------------------------------------------------------------------------------
>
>                 Key: KAFKA-734
>                 URL: https://issues.apache.org/jira/browse/KAFKA-734
>             Project: Kafka
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>            Priority: Blocker
>              Labels: p1
>         Attachments: kafka-734-v1.patch
>
>
> Migration tool has a number of problems ranging from poor logging to poor 
> design. This needs to be thought through again

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to