The bug bit me, so reapplied my patch on the latest from the 0.8 branch. I pushed it up to my Git repo:
https://github.com/dchenbecker/kafka-sbt I got it back to the point where it compiles, tests, etc. The stumbling block last time was packaging, so there's still a fair bit of work to do there. I also ned to re-test cross builds with 2.9.1/2.9.2, since both of those had issues with EasyMock (fix in this patched version). If you have a github account I can add you to the repo if you want to use it as the workspace. I'm not an apache committer so I can't put a branch there. Derek On Wed, Dec 12, 2012 at 11:45 PM, Joe Stein <crypt...@gmail.com> wrote: > Hey Derek, I totally got swamped at work and didn't get a chance to bang on > the sbt change. > > I am not a sbt whiz you might be better to get this over the finish line is > it something you might be able to-do? > > if so I can review and commit, np > > IMHO 0.8 should not ship with out supporting latest sbt and scala in a good > way it is one thing I have heard time and again from Scala community folks > from perception, contributions, etc > > let me know if you don't have time I can figure some time to noodle and > bang away again at it last time I got it all down to one test failing but > some other tickets I should attend to also > > On Tue, Nov 20, 2012 at 4:21 PM, Derek Chen-Becker <de...@precog.com> > wrote: > > > I haven't had any time to work on it in a few months, but it's definitely > > something I'd like to finish up. I think the last remaining issue is that > > SBT isn't integrated into the external packaging scripts, but otherwise > it > > should work. > > > > Derek > > > > On Mon, Nov 19, 2012 at 9:24 PM, Joe Stein <crypt...@gmail.com> wrote: > > > > > I have not tried the KAFKA-139 ticket yet for latest scala but will > give > > > that a try this week. Looks cool. > > > > > > On Mon, Nov 19, 2012 at 7:11 PM, Derek Chen-Becker <de...@precog.com> > > > wrote: > > > > > > > In particular it breaks some tests between Scala 2.8.0 and 2.9.x due > to > > > > changes in Scala's collections impls that impact Map traversal > order. I > > > > haven't had any time to work further on the SBT cross-build/upgrade > > > ticket > > > > ( > > > > https://issues.apache.org/jira/browse/KAFKA-139), but that was > > > definitely > > > > a > > > > blocker. > > > > > > > > Derek > > > > > > > > On Mon, Nov 19, 2012 at 3:38 PM, Jay Kreps <jay.kr...@gmail.com> > > wrote: > > > > > > > > > What has people's experience with EasyMock been? > > > > > > > > > > I am really struggling with it. It seems to encourage reaching > inside > > > > > classes and programming an explicit list of calls they will make. > > This > > > > > makes the tests very fragile to internal changes. > > > > > > > > > > It also doesn't seem to play all that well with scala due to all > the > > > > > reflection. > > > > > > > > > > I was originally a big fan since it got us away from massive > > > > > non-deterministic integration tests. > > > > > > > > > > But I wonder if we wouldn't be better off just writing simple > > hand-made > > > > > mocks for major classes or increasing the quality of our test > > harnesses > > > > to > > > > > do integration testing...? > > > > > > > > > > Thoughts? > > > > > > > > > > -Jay > > > > > > > > > > > > > > > > > > > > > -- > > > > *Derek Chen-Becker* > > > > *Precog Lead Infrastructure Engineer* > > > > de...@precog.com > > > > 303-752-1700 > > > > > > > > > > > > > > > > -- > > > > > > /* > > > Joe Stein > > > http://www.linkedin.com/in/charmalloc > > > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop> > > > */ > > > > > > > > > > > -- > > *Derek Chen-Becker* > > *Precog Lead Infrastructure Engineer* > > de...@precog.com > > 303-752-1700 > > > > > > -- > > /* > Joe Stein > http://www.linkedin.com/in/charmalloc > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop> > */ > -- *Derek Chen-Becker* *Precog Lead Infrastructure Engineer* de...@precog.com 303-752-1700
