[
https://issues.apache.org/jira/browse/JSPWIKI-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292516#comment-17292516
]
Juan Pablo Santos Rodríguez commented on JSPWIKI-1146:
------------------------------------------------------
Hi [~rostskadat],
apologies for the delay answering back!
re. 3 & 4., you should be able to create an account at jspwiki-wiki.a.o, and
that should allow to create the page and add some info into it. Unfortunately,
the {{SpamFilter}} may pop up if the text contains something "suspicious" as
too many urls, or too many text, or too many changes.. :-/ JSPWIKI-1143 should
allow us more flexibility regarding doc. contributions. If it gets too annoying
I can bring the contents of the README.md file to the wiki (and whatever
needed). That page should have instructions on how to set up the search
provider, so code is always on git, and documentation at jspwiki-wiki.a.o. As
for the {{Dockerfile}}, I'd also put it on the documentation, but something
like:
{code:java}
# main dockerfile has been built previously
FROM jspwiki:2.11.0
RUN set -x \
# Copy Kendra Search Provider configuration
&& cp /tmp/jspwiki-custom.properties
$CATALINA_HOME/webapps/ROOT/WEB-INF/classes
{code}
(or something like that, haven't look in detail what's needed) noting the
custom properties on the same documentation page, with the rest of the
{{README.md}} file. I'd recall that JSPWiki should translate Docker {{ENV}}
directives to jspwiki properties changing the {{_}} with {{.}} so they can act
as another way of passing configuration, but have to check, I don't see it
noted at [https://jspwiki-wiki.apache.org/Wiki.jsp?page=Docker]
re. 5, I missed it was a json file, my bad. In this case an exclusion for that
file can be set on the [maven-rat-plugin
configuration|https://github.com/rostskadat/jspwiki/blob/master/pom.xml#L698]
re. 6, I've seen you've already cleaned up the tests using {{TestInfo}} and
some custom annotations, so I'm unsure if anything else can be done. The
{{TestEngine}} inherits {{WikiEngine}}, which stores all the managers on a
protected {{Map}}. Perhaps this {{Map}} can be made available through the
{{TestEngine}} and that would allow to overwrite managers with custom code. In
this case the amount of code would not decrease, though, as the bulk of the
test setup is to prepare the mock Kendra client. The other thing I can think of
is to instantiate the the KendraSearchProvider directly instead of obtaining it
through the engine. Then you can set up as you need and then manually call
{{initialize()}} (if needed) and perform the required tests.. One side
question, now that I'm looking at the test code, is the use of Awaitility
really needed? It was on the DefaultSearchProviderTest because it takes Lucene
a bit of time to initialize (JSPWiki init's it with a bit of delay on a
background thread in order to speed up the startup time)
Overall I'd say the code looks good to me! If you send the PR we can follow up
there.
thx,
juan pablo
> Add AWS Kendra as a Search Provider
> -----------------------------------
>
> Key: JSPWIKI-1146
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1146
> Project: JSPWiki
> Issue Type: New Feature
> Components: Search
> Affects Versions: 2.11.0-M8
> Reporter: Julien Masnada
> Priority: Minor
> Labels: features, pull-request-available
>
> We use AWS Kendra a central search tool in our organization to provide a
> search result that can span different Data Source (DB, Sharepoint, etc).
> Since we have a lot of documents in our Wiki, it is interesting for us to be
> able to index (in Kendra) and search pages and attachments from our wiki.
> Furthermore it is important to be able to search in attachments that are in
> PDF / Word / PPT or HTML format also.
> We have implemented a SearchProvider that does the job of indexing and
> returning search result. The code is available in
> [https://github.com/rostskadat/jspwiki]
> Some further documentation is available in the README.
> I would appreciate if you could direct me toward a document explaining the
> process for requesting the inclusion of this feature
> Thanks
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
