[
https://issues.apache.org/jira/browse/JSPWIKI-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17288335#comment-17288335
]
Julien Masnada commented on JSPWIKI-1146:
-----------------------------------------
[~juanpablo] thanks for your feedback. Let me take your suggestions in order:
# The license notice for {{{{aws-java-sdk-kendra}}}} has been updated.
# The dependency has been added to the {{dependenciesManagement}} section.
# The docker file allows me to generate an image pre-configured with the
KendraSearchProvider and thus showing the use of the properties for the plugin.
I can remove it but I though that it could be useful.
# I tried to create the corresponding page on
[jspwiki-wiki.apache.org|jspwiki-wiki.apache.org] but it tells me that it has
been rejected by the spam filter. Please advise.
# Added the license header for {{index-and-datasource.yaml}}. However I can
not add it to the other file as this is a JSON file. Please advise.
# For the unit test I'm kind of in a pickle. I'm trying to inject the Kendra
client early on, however the since the WikiProvider.initialize() is called
extremely early there are no clean way that I can think of in order to be able
to inject the mock object required to isolate the kendra client. The resulting
unit test code is kind of cumbersome and really ugly. Do you happen to know
another piece of code that has these characteristics (external library that
uses an external service, and thus need mocking)?
> Add AWS Kendra as a Search Provider
> -----------------------------------
>
> Key: JSPWIKI-1146
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1146
> Project: JSPWiki
> Issue Type: New Feature
> Components: Search
> Affects Versions: 2.11.0-M8
> Reporter: Julien Masnada
> Priority: Minor
> Labels: features, pull-request-available
>
> We use AWS Kendra a central search tool in our organization to provide a
> search result that can span different Data Source (DB, Sharepoint, etc).
> Since we have a lot of documents in our Wiki, it is interesting for us to be
> able to index (in Kendra) and search pages and attachments from our wiki.
> Furthermore it is important to be able to search in attachments that are in
> PDF / Word / PPT or HTML format also.
> We have implemented a SearchProvider that does the job of indexing and
> returning search result. The code is available in
> [https://github.com/rostskadat/jspwiki]
> Some further documentation is available in the README.
> I would appreciate if you could direct me toward a document explaining the
> process for requesting the inclusion of this feature
> Thanks
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
