On 03/03/14 17:45, Harry Metske (JIRA) wrote:

     [ 
https://issues.apache.org/jira/browse/JSPWIKI-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918305#comment-13918305
 ]

Harry Metske commented on JSPWIKI-814:
--------------------------------------

Brian,

I applied all three patches, but the last one (for VersioningFileProviderTest) results in 
a compilation error, on several places the "injectFile" method is used, but 
this method does not exist.

Very strange!! That must be a consequence of me spending hours hacking the patch files so they don't eliminate all the tabs, trailing spaces, etc!

Do you mean the trunk is currently broken? I'll get you another fix asap.

Very sorry.

One other request, can you use the extension .patch for patch files, makes it a 
lot easier to handle them.

Yes, I can call them "*.patch" in future. As a linux user, I'm afraid I forgot that windows cares about the final segment of the filename. It's all the same to me!

Thanks very much for making the commits. Once again, sorry about the error. Watch this space...

Brian


VersioningFileProvider does migrate original page properties
------------------------------------------------------------

                 Key: JSPWIKI-814
                 URL: https://issues.apache.org/jira/browse/JSPWIKI-814
             Project: JSPWiki
          Issue Type: Bug
          Components: Core & storage
    Affects Versions: 2.10
         Environment: ubuntu linux and openjdk 1.7.0_25. mvn test.
            Reporter: Brian Burch
            Priority: Minor
              Labels: features
             Fix For: FutureVersion

         Attachments: JSPWIKI-814-patchNew-TestEngine, 
JSPWIKI-814-patchNew-VersioningFileProvider, 
JSPWIKI-814-patchNew-VersioningFileProviderTest

   Original Estimate: 24h
  Remaining Estimate: 24h

The default FileSystemProvider maintains two files for each wiki page. e.g. 
MyPage.txt has an associated MyPage.properties, which records the timestanp and 
author of the last change to that page.
VersioningFileProvider contains logic to "migrate" a wiki page created by 
FileSystemProvider when it is next updated. This migration works properly for MyPage.txt, 
but the new change history for the page in the OLD/ subdirectory starts at version 2 and 
ignores the history available in MyPage.properties.
Also, the original MyPage.properties remains in "suspended animation", even 
though the migrated page history has been created.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Reply via email to