[
https://issues.apache.org/jira/browse/JSPWIKI-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902681#comment-13902681
]
Brian Burch commented on JSPWIKI-814:
-------------------------------------
I added a new, fairly complex, test case to examine the behaviour of my change
when PageManager.PROP_USECACHE was false to disable page caching. This new case
failed, but I fixed it. The fix threw up some more failures in
previously-working test cases. I resolved all the problems by cloning the code
fragment that enhances performance by maintaining a one-level cache of the most
recently access properties of each individual page. Having fixed the failures,
I then refactored the properties cache logic to remove a lot of the duplicated
code.
I think this set of three patches is ready to be committed to the trunk... if
someone had a bit of time to spare.
> VersioningFileProvider does migrate original page properties
> ------------------------------------------------------------
>
> Key: JSPWIKI-814
> URL: https://issues.apache.org/jira/browse/JSPWIKI-814
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.10
> Environment: ubuntu linux and openjdk 1.7.0_25. mvn test.
> Reporter: Brian Burch
> Priority: Minor
> Labels: features
> Fix For: FutureVersion
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The default FileSystemProvider maintains two files for each wiki page. e.g.
> MyPage.txt has an associated MyPage.properties, which records the timestanp
> and author of the last change to that page.
> VersioningFileProvider contains logic to "migrate" a wiki page created by
> FileSystemProvider when it is next updated. This migration works properly for
> MyPage.txt, but the new change history for the page in the OLD/ subdirectory
> starts at version 2 and ignores the history available in MyPage.properties.
> Also, the original MyPage.properties remains in "suspended animation", even
> though the migrated page history has been created.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
