"0" from me.
1. I don't quite understand why the version of ignite-spring-data-ext is
2.2.0?
There were already versions released earlier:
ignite-spring-data-ext 1.0.0
ignite-spring-data-2.0-ext 1.0.0
ignite-spring-data-2.2-ext 1.0.0
Artifacts ignite-spring-data-ext and ignite-spring-data-2.0-ext were
deleted, artifact ignite-spring-data-2.2-ext was moved to
ignite-spring-data-ext, but why did the version become 2.2.0? Looks
illogical to me. Current version of this artifact in master branch is
2.0.0-SNAPSHOT, we should just remove the "-SNAPSHOT" word while releasing.
Binding ignite-spring-data-ext version to some outdated spring-data
version, in my opinion, is not correct. BTW, the last released version of
spring-data is 2.6.4, we include as dependency 2.2 version, but perhaps it
should be with "provided" scope.
2. Release files doesn't include pom.xml file in the root directory, but
according to included file DEVNOTES.md to build extensions we should run:
mvn clean install -DskipTests -Pcheckstyle
This command can't be executed without a root pom.xml file (the previous
releases of ignite-spring-data-ext contains this file).
3. With JDK 11 there is a problem when building using command line from
DEVNOTES.md ("mvn clean install -f modules/...-ext -Pcheckstyle"), tests
use reflection and should be run with additional "--add-opens" options. Or
there should be instructions in DEVNOTES.md how to build without running
tests (-DskipTests option).
Also, there are problems with javadoc processing during build, if the
ignite-tools artifact was built using JDK 8.
I was able to build with JDK 11 only using this command line:
mvn clean install -f modules/ignite-spring-data-parent-ext -Pcheckstyle
-DskipTests -Dmaven.javadoc.skip=true
So, we should explicitly note in DEVNOTES that build is possible only with
JDK 8 or fix command lines to build with higher JDK versions.
4. Strange directory names in "modules" directory. For example,
"ignite-spring-data-parent-ext" in the released zip file, but
"spring-data-ext" (with the same content) in the master branch.
ср, 4 мая 2022 г. в 17:43, Andrey Gura <ag...@apache.org>:
> +1
>
> On Fri, Apr 29, 2022 at 7:22 PM Nikita Amelchev <namelc...@apache.org>
> wrote:
> >
> > +1
> >
> > пт, 29 апр. 2022 г. в 17:54, Anton Vinogradov <a...@apache.org>:
> > >
> > > +1
> > >
> > > On Fri, Apr 29, 2022 at 5:28 PM Maxim Muzafarov <mmu...@apache.org>
> wrote:
> > >
> > > > Dear Community,
> > > >
> > > >
> > > > The release candidates are ready. See the links below.
> > > >
> > > >
> > > > == Ignite Spring Data Extension Module 2.2.0 ==
> > > >
> > > > The release candidate is uploaded to:
> > > >
> > > >
> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-data-ext-2.2.0-rc1/
> > > >
> > > > The following Maven staging can be used:
> > > >
> > > >
> https://repository.apache.org/content/repositories/orgapacheignite-1547/org/apache/ignite/ignite-spring-data-ext/
> > > >
> > > > Tag:
> > > >
> > > >
> https://github.com/apache/ignite-extensions/releases/tag/ignite-spring-data-ext-2.2.0-rc1
> > > >
> > > > RELEASE_NOTES:
> > > >
> > > >
> https://github.com/apache/ignite-extensions/blob/release/ignite-spring-data-ext-2.2.0/modules/spring-data-ext/spring-data/RELEASE_NOTES.txt
> > > >
> > > > DEVNOTES:
> > > > https://github.com/apache/ignite-extensions/blob/master/DEVNOTES.md
> > > >
> > > > Release Checker Results:
> > > >
> > > >
> https://github.com/apache/ignite-extensions/runs/6229346844?check_suite_focus=true
> > > >
> > > >
> > > >
> > > > == Ignite Spring Session Extension Module 1.0.0 ==
> > > >
> > > > The release candidate is uploaded to:
> > > >
> > > >
> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-session-ext-1.0.0-rc1/
> > > >
> > > > The following Maven staging can be used:
> > > >
> > > >
> https://repository.apache.org/content/repositories/orgapacheignite-1548/org/apache/ignite/ignite-spring-session-ext/
> > > >
> > > > Tag:
> > > >
> > > >
> https://github.com/apache/ignite-extensions/releases/tag/ignite-spring-session-ext-1.0.0-rc1
> > > >
> > > > RELEASE_NOTES:
> > > >
> > > >
> https://github.com/apache/ignite-extensions/blob/release/ignite-spring-session-ext-1.0.0/modules/spring-session-ext/RELEASE_NOTES.txt
> > > >
> > > > DEVNOTES:
> > > > https://github.com/apache/ignite-extensions/blob/master/DEVNOTES.md
> > > >
> > > > Release Checker Results:
> > > >
> > > >
> https://github.com/apache/ignite-extensions/runs/6229613223?check_suite_focus=true
> > > >
> > > >
> > > > == Ignite Zookeeper Ip Finder Extension Module 1.0.0 ==
> > > >
> > > > The release candidate is uploaded to:
> > > >
> > > >
> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-zookeeper-ip-finder-ext-1.0.0-rc1/
> > > >
> > > > The following Maven staging can be used:
> > > >
> > > >
> https://repository.apache.org/content/repositories/orgapacheignite-1549/org/apache/ignite/ignite-zookeeper-ip-finder-ext/
> > > >
> > > > Tag:
> > > >
> > > >
> https://github.com/apache/ignite-extensions/releases/tag/ignite-zookeeper-ip-finder-ext-1.0.0-rc1
> > > >
> > > > RELEASE_NOTES:
> > > >
> > > >
> https://github.com/apache/ignite-extensions/blob/release/ignite-zookeeper-ip-finder-ext-1.0.0/modules/zookeeper-ip-finder-ext/zookeeper-ip-finder/RELEASE_NOTES.txt
> > > >
> > > > DEVNOTES:
> > > > https://github.com/apache/ignite-extensions/blob/master/DEVNOTES.md
> > > >
> > > > Release Checker Results:
> > > >
> > > >
> https://github.com/apache/ignite-extensions/runs/6210193576?check_suite_focus=true
> > > >
> > > >
> > > >
> > > > The vote is formal, see voting guidelines
> > > > https://www.apache.org/foundation/voting.html
> > > >
> > > > +1 - to accept (Ignite Spring Data 2.2.0 RC1, Ignite Spring Session
> > > > 1.0.0 RC1, Ignite Zookeeper IP Finder 1.0.0 RC1)
> > > > 0 - don't care either way
> > > > -1 - DO NOT accept (explain why)
> > > >
> > > > See notes on how to verify release here
> > > > https://www.apache.org/info/verification.html
> > > > and
> > > >
> > > >
> https://cwiki.apache.org/confluence/display/IGNITE/Release+Process#ReleaseProcess-P5.VotingonReleaseandReleaseVerification
> > > >
> > > >
> > > > This vote will be open for at least 7 days till Sat May 7, 2022,
> > > > 14:00 Moscow TZ. Please, write me down the thread if you need
> > > > additional time to check the release.
> > > >
> > > >
> > > >
> https://www.timeanddate.com/countdown/vote?iso=20220507T14&p0=166&msg=%5BVOTE%5D+Release+Extensions+Ignite+Spring+Data+2.2.0+RC1%2C+Ignite+Spring+Session+1.0.0+RC1%2C+Ignite+Zookeeper+IP+Finder+1.0.0+RC1&font=sanserif
> > > >
> >
> >
> >
> > --
> > Best wishes,
> > Amelchev Nikita
>
