Ok, thank you, I've missed the start of the discussion пн, 14 окт. 2019 г. в 11:13, Ivan Pavlukhin <vololo...@gmail.com>:
> Alexey, Petr, > > Please read first message in this thread. Now checkstyle is a part of > [Build > Apache Ignite]. > > If you still have any questions after that please write back. > Sincerely, I do not want us to repeat the discussion as it was > detailed enough and in my opinion Maxim did the change gracefully. > > пн, 14 окт. 2019 г. в 10:34, Petr Ivanov <mr.wei...@gmail.com>: > > > > Maksim, why have you removed Checkstyle from Run All? > > > > > > > On 13 Oct 2019, at 18:52, Maxim Muzafarov <mmu...@apache.org> wrote: > > > > > > Igniters, > > > > > > The `checkstyle` profile has been enabled for the Apache Ignite build > procedure. > > > Unused imports in the spark module have been fixed [1]. > > > The `[Check Code Style]` suite has been excluded from `Run :: All`, > > > `Run :: ML`. > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-12287 > > > > > > On Tue, 8 Oct 2019 at 08:47, Ivan Pavlukhin <vololo...@gmail.com> > wrote: > > >> > > >> Let's give it a try. > > >> > > >> пн, 7 окт. 2019 г. в 13:21, Nikolay Izhikov <nizhi...@apache.org>: > > >>> > > >>> +1 > > >>> > > >>> В Пн, 07/10/2019 в 13:18 +0300, Maxim Muzafarov пишет: > > >>>> Igniters, > > >>>> > > >>>> > > >>>> I'm planning October 11 (Friday) 22-00 MSK enable `checkstyle` > profile > > >>>> on the [Build > > >>>> Apache Ignite] suite by the end of the next weekend (one week test > > >>>> period). Such an option discussed many times before (e.g. [1]). > > >>>> > > >>>> Here are the reasons: > > >>>> > > >>>> - any code style violations in a PR lead to source code fixes which > in > > >>>> turn require re-run of other test suites, so it is better to fail > > >>>> fast; > > >>>> - each a new Run:All suite (e.g. for a new module) must contain a > > >>>> checkstyle suite to code style by default, so it is better to > include > > >>>> mandatory checks to the build Apache Ignite procedure; > > >>>> - `fail fast` paradigm will eliminate all the check style > violations, > > >>>> currently in happens time ot time; > > >>>> > > >>>> The ability to create a prototype PR without code style checks still > > >>>> exists. You can disable `checkstyle` profile for such PRs in your > > >>>> local branches. > > >>>> > > >>>> > > >>>> Any objections? > > >>>> > > >>>> > > >>>> [1] > http://apache-ignite-developers.2346864.n4.nabble.com/Code-inspection-td27709i80.html#a41297 > > >> > > >> > > >> > > >> -- > > >> Best regards, > > >> Ivan Pavlukhin > > > > > -- > Best regards, > Ivan Pavlukhin >
