+1 В Пн, 07/10/2019 в 13:18 +0300, Maxim Muzafarov пишет: > Igniters, > > > I'm planning October 11 (Friday) 22-00 MSK enable `checkstyle` profile > on the [Build > Apache Ignite] suite by the end of the next weekend (one week test > period). Such an option discussed many times before (e.g. [1]). > > Here are the reasons: > > - any code style violations in a PR lead to source code fixes which in > turn require re-run of other test suites, so it is better to fail > fast; > - each a new Run:All suite (e.g. for a new module) must contain a > checkstyle suite to code style by default, so it is better to include > mandatory checks to the build Apache Ignite procedure; > - `fail fast` paradigm will eliminate all the check style violations, > currently in happens time ot time; > > The ability to create a prototype PR without code style checks still > exists. You can disable `checkstyle` profile for such PRs in your > local branches. > > > Any objections? > > > [1] > http://apache-ignite-developers.2346864.n4.nabble.com/Code-inspection-td27709i80.html#a41297
signature.asc
Description: This is a digitally signed message part
