Hello! I have reviewed your code and commented IGNITE-7107 for a list of potential problem.
I think everything from the first "blocker" section ought to be fixed before this patch is merged, while "nice to have" things may be spinned out as separate tickets. I suggest moving scripts that don't work with non-writable JAVA_HOME to examples section. This will likely include benchmarks, which I didn't try (but suggest you to). Regards, -- Ilya Kasnacheev 2017-12-19 13:23 GMT+03:00 vveider <mr.wei...@gmail.com>: > Done. See updated PR#3171 [1] > > > [1] https://github.com/apache/ignite/pull/3171 > > > > -- > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ >
