-1 (non-binding)

Very excited to see this go through! 0.2.0 will finally allow us to publish
our hard work on the Terraform Registry! Thanks to Matt and the community
for all of the hard work

That being said, it looks like the LICENSEs / NOTICEs are out-of-date. I've
sent out https://github.com/apache/terraform-provider-iceberg/pull/147 to
make sure that the license checker is actually run in CI.

On Fri, Oct 23, 2026 at 10:02 AM Xuanwo <[email protected]> wrote:

> +1 (non-binding)
>
> I checked:
>
> - Checksum and signature of the source tarball are valid (signed by Matt
> Topol's key from Iceberg KEYS)
> - The v0.2.0-rc0 tag is signed and points to
> b63cd68afa69f58fae1d4b9637a48268111ffdfd
> - The source tarball matches git archive of that commit
> - LICENSE and NOTICE are present, and Apache RAT passes
> - No unexpected binary files in the source release
> - Built from the source tarball with Go 1.25 and unit tests pass
> - go mod verify passes
> - SHA256SUMS.sig of the convenience binaries is valid, and all binary ZIPs
> match SHA256SUMS
>
> Thanks Matt for driving this release!
>
> Xuanwo
>

Reply via email to