+1 on the linter. Thanks Kevin! Yufei
On Wed, Dec 3, 2025 at 11:55 PM Eduard Tudenhöfner <[email protected]> wrote: > Thanks Kevin for looking into this and the changes LGTM. > > On Wed, Dec 3, 2025 at 6:30 PM Kevin Liu <[email protected]> wrote: > >> Hey folks, >> >> I have an open PR #14686[1] to add a new yaml linter and to enforce >> consistent formatting for these 2 spec yamls: >> - *open-api/rest-catalog-open-api.yaml* >> - *aws/src/main/resources/s3-signer-open-api.yaml* >> >> It is using the python `yamllint` tool [2] and introduces 3 new >> make commands: >> ``` >> make validate-spec >> make lint-spec >> make lint # runs the 2 above >> ``` >> The linter is enforced in CI via the "Open-API" github workflow. >> >> The PR itself introduces minor formatting changes, and aims to make as >> few changes as possible. We can continue to iterate on the formatting rules >> in `open-api/.yamllint`. >> Please take a look! >> >> Best, >> Kevin Liu >> >> >> [1] https://github.com/apache/iceberg/pull/14686 >> [2] https://pypi.org/project/yamllint/ >> [3] >> https://github.com/apache/iceberg/blob/bfe06a540d9d31d89b5161b20dcdcf6b1b6e2ef4/.github/workflows/open-api.yml#L50-L52 >> >
