Thanks for the callout JB. I also double checked that only the `lib.rs` file from the `sqllogictest` crate contains a comment referencing Apache Datafusion.
Thanks to everyone for testing, verifying, and voting on 0.5.1 RC1. The 72-hour period has passed and we have the necessary number of binding votes to accept the release candidate as Apache Iceberg Rust v0.5.1. The vote PASSED with 3 +1 binding votes and 6 +1 non-binding votes, no +0 or -1 votes. I will coordinate with a PMC member to complete the release with this RC and send out the official release mail shortly. Best, Kevin Liu On Sat, May 31, 2025 at 12:32 AM Xuanwo <xua...@apache.org> wrote: > Hi, JB > > Thanks a lot for the check! > > > imho, LICENSE should mention that > > craters lib.rs contains code from Apache Datafusion > > I'm assuming you're referring to "crates/sqllogictest/src/lib.rs". > > The relevant code has been extracted into `datafusion-sqllogictest`, which > we now use as a dependency. As a result, we no longer have that code. I'll > go ahead and remove the incorrect comment instead. > > Link: > https://github.com/apache/iceberg-rust/blob/main/crates/sqllogictest/src/lib.rs > > > - ASF headers are OK (tsv files are OK) > > Those TSV files are included as part of our BOM, which contains all our > dependencies. Perhaps we could use a different format or choose not to > include them in our source release at all. > > On Sat, May 31, 2025, at 12:46, Jean-Baptiste Onofré wrote: > > +1 (non binding) > > > > I checked: > > - checksum and signature are good > > - LICENSE/NOTICE is good. Nit: imho, LICENSE should mention that > > craters lib.rs contains code from Apache Datafusion > > - no binary found in the source distribution (puffin testdata is ok) > > - ASF headers are OK (tsv files are OK) > > > > Thanks ! > > Regards > > JB > > > > On Tue, May 27, 2025 at 7:08 AM Kevin Liu <kevinjq...@apache.org> wrote: > >> > >> Hello Apache Iceberg Rust Community, > >> > >> This is a call for a vote to release Apache Iceberg rust version 0.5.1 > >> The tag to be voted on is v0.5.1-rc.1 > >> > >> The release candidate: > >> > https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-rust-0.5.1-rc.1/ > >> > >> Keys to verify the release candidate: > >> https://downloads.apache.org/iceberg/KEYS > >> > >> Git tag for the release: > >> https://github.com/apache/iceberg-rust/releases/tag/v0.5.1-rc.1 > >> > >> Please download, verify, and test. > >> > >> The VOTE will be open for at least 72 hours and until the necessary > >> number of votes are reached. > >> [ ] +1 approve > >> [ ] +0 no opinion > >> [ ] -1 disapprove with the reason > >> > >> To learn more about Apache Iceberg, please see > https://rust.iceberg.apache.org/ > >> > >> Checklist for reference: > >> [ ] Download links are valid. > >> [ ] Checksums and signatures. > >> [ ] LICENSE/NOTICE files exist > >> [ ] No unexpected binary files > >> [ ] All source files have ASF headers > >> [ ] Can compile from source > >> > >> More detailed checklist please refer to: > >> https://github.com/apache/iceberg-rust/tree/main/scripts > >> > >> To compile from source, please refer to: > >> https://github.com/apache/iceberg-rust/blob/main/CONTRIBUTING.md > >> > >> Here is a Python script in release to help you verify the release > candidate: > >> ./scripts/verify.py > >> > >> Note, there was an issue during the release process for 0.5.0 for the > rust crates but `pyiceberg-core` was successfully published to pypi. Thus, > we yank'ed the 0.5.0 version on pypi and created a new release version. > >> > >> Best, > >> Kevin Liu > >> > > -- > Xuanwo > > https://xuanwo.io/ >
