+1 (binding) Thanks Szehon
On Mon, May 12, 2025 at 9:19 AM Russell Spitzer <russell.spit...@gmail.com> wrote: > +1 (binding) > > On Mon, May 12, 2025 at 5:32 AM Eduard Tudenhöfner < > etudenhoef...@apache.org> wrote: > >> +1 (binding) >> >> On Mon, May 12, 2025 at 3:45 AM Gang Wu <ust...@gmail.com> wrote: >> >>> +1 (non-binding) >>> >>> On Mon, May 12, 2025 at 3:27 AM Kevin Liu <kevinjq...@apache.org> wrote: >>> >>>> +1 (non-binding) >>>> >>>> Thanks for starting a vote. >>>> >>>> There's extra context in the PR description. As a summary, >>>> `gz.metadata.json` is the current naming convention for GZIP compressed >>>> metadata.json file and is implemented in both java >>>> <https://github.com/apache/iceberg/blob/97c0e136b8021058897cab7539e3ef89ce5a0341/core/src/main/java/org/apache/iceberg/TableMetadataParser.java#L69-L83> >>>> and python >>>> <https://github.com/apache/iceberg-python/blob/82e025ee73f04e6174bb1b4d853804d609ca5b67/pyiceberg/serializers.py#L35>. >>>> `metadata.json.gz` is considered the backwards-compatible naming scheme. >>>> We agreed to address expanding the naming convention at a later time. >>>> This PR just documents the current implementations. >>>> >>>> Best, >>>> Kevin Liu >>>> >>>> On Sun, May 11, 2025 at 11:48 AM Micah Kornfield <emkornfi...@gmail.com> >>>> wrote: >>>> >>>>> This vote is to merge https://github.com/apache/iceberg/pull/12598 >>>>> which documents that GZIP is supported for metadata files and >>>>> implementation details for how gzip files are currently recognized. >>>>> >>>>> The vote will remain open for at least 72 hours. >>>>> >>>>> [ ] +1 Merge the change >>>>> [ ] +0 >>>>> [ ] -1 Do not merge the change because. >>>>> >>>>> >>>>> Thanks, >>>>> Micah >>>>> >>>>>
