Hi Max, +1 on that too. IcebergSink has been hanging around for a while now. We want to make sure we have the same features, though:
I’ve got https://github.com/apache/iceberg/pull/12071 that adds the Range Distribution Mode to IcebergSink. It still needs a few recent bug fixes and features backported, but it should be ready soon. On Thu, Mar 6, 2025 at 8:18 AM Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > Hi Max, > > I guess you are proposing to remove FlinkSink and the corresponding > FlinkSource as well. > > It makes to me as, I saw in the code, that both FlinkSink and > FlinkSource are deprecated for a while. > > So, +1 to remove it. > > Are you planning this for 1.9.0 ? > > Regards > JB > > On Thu, Mar 6, 2025 at 4:21 PM Maximilian Michels <m...@apache.org> wrote: > > > > Hi, > > > > Today there are two Flink write connectors in Iceberg: > > > > 1. FlinkSink (original sink, based on Flink legacy interfaces) > > 2. IcebergSink (newer version, based on modern Flink API) > > > > In terms of features, (1) is a subset of (2). > > > > I'm in the process of adding support for Flink 2.0. The interfaces > > used for (1) have been deprecated for several Flink versions and are > > removed / discouraged in Flink 2.0. > > > > Therefore, I would like to propose to remove FlinkSink for the Flink > > 2.0 Iceberg module. We have already deprecated FlinkSink for a while. > > > > Any objections? > > > > -Max >
