Thanks everyone for joining the discussion, I'll submit a jira ticket to enable it for iceberg-rust, iceberg-cpp, iceberg-go, and pyiceberg.
On Mon, Jan 20, 2025 at 9:44 AM Junwang Zhao <zhjw...@gmail.com> wrote: > hi Renjie, > > It would be great if iceberg-cpp adopt the same methodology. > > Regards > Junwang Zhao > > > On Wed, Jan 15, 2025 at 21:16 Renjie Liu <liurenjie2...@gmail.com> wrote: > >> Hi, Raul: >> >> Adding a pull request template sounds like a good idea to me, and I'll >> fire a pr for it. >> >> Hi, Kevin: >> >> I'm happy to take the effort to open an apache infra ticket for iceberg, >> iceberg-go, iceberg-python if we reached agreement. >> >> On Wed, Jan 15, 2025 at 6:26 PM Raúl Cumplido <rau...@apache.org> wrote: >> >>> +1 (non-binding) >>> >>> That's how we do it on Apache Arrow too. I would recommend using a pull >>> request template too which gives some consistency to the commit messages. >>> >>> As an example the Arrow Go one here: >>> https://github.com/apache/arrow-go/blob/main/.github/pull_request_template.md >>> >>> Regards, >>> Raúl >>> >>> El mar, 14 ene 2025 a las 22:57, Kevin Liu (<kevinjq...@apache.org>) >>> escribió: >>> >>>> +1 non-binding. >>>> Thanks for bringing this up! I wasn’t aware that GitHub supports this >>>> option. I've often had to track down a commit and then go to its PR page to >>>> view more information. This change would make the process much more >>>> streamlined. >>>> >>>> I'd also like to propose enabling this for `iceberg-python` and >>>> possibly for `iceberg-go` as well. >>>> >>>> Best, >>>> Kevin Liu >>>> >>>> On Mon, Jan 13, 2025 at 9:03 PM Honah J. <hon...@apache.org> wrote: >>>> >>>>> Hi everyone, >>>>> >>>>> +1 >>>>> >>>>> I remember that I manually copy-pasting PR descriptions into merge >>>>> commit messages multiple times. PRs often accumulate numerous commits >>>>> during reviews, resulting in overly lengthy and less useful commit >>>>> messages. Using the PR description as the default merge commit message >>>>> seems like a more helpful and effective approach. >>>>> >>>>> Best regards, >>>>> Honah >>>>> >>>>> On Mon, Jan 13, 2025 at 8:15 PM Xuanwo <xua...@apache.org> wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> Here is my +1 non-binding. >>>>>> >>>>>> I have to change the merge commit from time to time. This setting >>>>>> change will help a lot. >>>>>> >>>>>> On Tue, Jan 14, 2025, at 11:49, Renjie Liu wrote: >>>>>> >>>>>> Hi, all: >>>>>> >>>>>> I want to propose to change the github option in iceberg-rust to use >>>>>> pr title + pr description as default git commit title and message, and >>>>>> github already has support for this >>>>>> <https://github.blog/changelog/2022-08-23-new-options-for-controlling-the-default-commit-message-when-merging-a-pull-request/> >>>>>> . >>>>>> >>>>>> Currently when we use squash commits to merge a pr, the default git >>>>>> commit title is pr title, while git commit message is the combined >>>>>> message >>>>>> of each commit. In most cases pr description contains more detailed >>>>>> information describing what's happening while the commit message in each >>>>>> commit is somehow cluttered with random messages. >>>>>> >>>>>> Looking forward to hearing from you! >>>>>> >>>>>> Xuanwo >>>>>> >>>>>> https://xuanwo.io/ >>>>>> >>>>>>
