+1 (binding) Verified sigs/checksums, license checks, and ran tests.
Thanks all, pretty cool to see all the developments in the project! - Amogh Jahagirdar On Mon, Dec 23, 2024 at 2:53 PM Kevin Liu <kevinjq...@apache.org> wrote: > Hey Sung, > > Thanks for the new RC! > > +1 (non-binding) > - [x] Download links are valid > - [x] Checksums and signatures > - [x] LICENSE/NOTICE files exist > - [x] No unexpected binary files > - [x] All source files have ASF header > - [x] Can compile from source > - [x] `./scripts/verify.py` > - [x] `make test` on M1 with Orbstack > - [x] Built and ran tests for `pyiceberg_core` following > https://github.com/apache/iceberg-rust/tree/main/bindings/python > - [x] Installed python library and ran an example of utilizing > `pyiceberg_core.transform.bucket` function > > Here are my notes, > https://gist.github.com/kevinjqliu/324cf98cbfbb8a4fa0b74b0bee399349 > <https://gist.github.com/kevinjqliu/324cf98cbfbb8a4fa0b74b0bee399349> > > As a reminder, running integration tests on MacOS requires docker > alternatives such as Orbstack or podman. MacOS with Native Docker has > limitations documentated at > https://github.com/apache/iceberg-rust/blob/main/CONTRIBUTING.md#install-docker-or-podman > and apache/iceberg-rust/#748 > <https://github.com/apache/iceberg-rust/pull/748> > > Best, > Kevin Liu > > On Mon, Dec 23, 2024 at 1:41 PM Christian Thiel < > christian.t.b...@gmail.com> wrote: > >> +1 non-binding >> >> [x] Download links are valid. >> [x] Checksums and signatures. >> [x] Can compile from source >> [x] Ran tests >> >> I also ran our integration test matrix with spark, pyiceberg, trino and >> starrocks against a Lakekeeber based on the rc. Cross-build for >> x86_64-unknown-linux-gnu, x86_64-unknown-linux-musl, >> aarch64-unknown-linux-musl >> and aarch64-apple-darwin. >> >> >> On 23. Dec 2024, at 17:45, Barron Wei <barronwei...@gmail.com> wrote: >> >> +1 non-binding >> >> [x] Download links are valid >> [x] Checksums and signatures >> [x] LICENSE/NOTICE files exist >> [x] No unexpected binary files >> [x] All source files have ASF headers >> [x] Can compile from source >> >> Ran verify.py and make test on macOS M2 with OrbStack. >> >> On 2024/12/20 15:13:01 Sung Yun wrote: >> > Hello, Apache Iceberg Rust Community, >> > >> > This is a call for a vote to release Apache Iceberg rust version 0.4.0. >> > >> > The tag to be voted on is v0.4.0-rc.3. >> > >> > This RC includes the following fixes: >> > - Reading a table with positional deletes should fail >> > - verify.py script should be executable >> > >> > The release candidate: >> > >> > >> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-rust-0.4.0-rc.3/ >> > >> > Keys to verify the release candidate: >> > >> > https://downloads.apache.org/iceberg/KEYS >> > >> > Git tag for the release: >> > >> > https://github.com/apache/iceberg-rust/tree/v0.4.0-rc.3 >> > >> > The associated convenience artifact for pyiceberg_core can be >> > downloaded by running the following command: >> > >> > `pip install -i https://test.pypi.org/simple/ pyiceberg-core` >> > >> > All notable features and fixes introduced in this release are >> > documented in the changelog: >> > >> > https://github.com/apache/iceberg-rust/blob/main/CHANGELOG.md >> > >> > Please download, verify, and test. >> > >> > The VOTE will be open for at least 72 hours and until the necessary >> > number of votes are reached. >> > >> > [ ] +1 approve >> > [ ] +0 no opinion >> > [ ] -1 disapprove with the reason >> > >> > To learn more about Apache Iceberg, please see >> https://rust.iceberg.apache.org/ >> > >> > Checklist for reference: >> > >> > [ ] Download links are valid. >> > [ ] Checksums and signatures. >> > [ ] LICENSE/NOTICE files exist >> > [ ] No unexpected binary files >> > [ ] All source files have ASF headers >> > [ ] Can compile from source >> > >> > More detailed checklist please refer to: >> > https://github.com/apache/iceberg-rust/tree/main/scripts >> > >> > To compile from source, please refer to: >> > https://github.com/apache/iceberg-rust/blob/main/CONTRIBUTING.md >> > >> > Here is a Python script in release to help you verify the release >> candidate: >> > >> > ./scripts/verify.py >> > >> > Thank you again for your time in helping verify the release. >> > >> > Sung >> > >> >> >>
