Hey everyone, Unfortunately -1 (binding) from my end.
It looks like we're able to read tables with merge-on-read deletes and we silently ignore them. This leads to data correctness issues and should be fixed before releasing it to the public. See #826 <https://github.com/apache/iceberg-rust/pull/826> for details. Kind regards, Fokko Op do 19 dec 2024 om 07:41 schreef Jean-Baptiste Onofré <j...@nanthrax.net>: > +1 (non binding) > > I checked: > - hash and signature are OK > - LICENSE and NOTICE look good > - ASF header is present in all files > - no binary file found in the source distribution > - build is ok (I just had to fix an local issue with cargo but it was > on my machine) > > Regards > JB > > On Wed, Dec 18, 2024 at 2:22 AM Sung Yun <sungwy...@gmail.com> wrote: > > > > Hello, Apache Iceberg Rust Community, > > > > This is a call for a vote to release Apache Iceberg rust version > v0.4.0-rc.2. > > > > The tag to be voted on is v0.4.0-rc.2. > > > > The release candidate: > > > > > https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-rust-0.4.0-rc.2/ > > > > Keys to verify the release candidate: > > > > https://downloads.apache.org/iceberg/KEYS > > > > Git tag for the release: > > > > https://github.com/apache/iceberg-rust/releases/tag/v0.4.0-rc.2 > > > > The associated convenience artifact for pyiceberg_core can be > > downloaded by running the following command: > > > > `pip install -i https://test.pypi.org/simple/ pyiceberg-core` > > > > All notable features and fixes introduced in this release are > > documented in the changelog: > > > > https://github.com/apache/iceberg-rust/blob/main/CHANGELOG.md > > > > Please download, verify, and test. > > > > The VOTE will be open for at least 72 hours and until the necessary > > number of votes are reached. > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > To learn more about Apache Iceberg, please see > https://rust.iceberg.apache.org/ > > > > Checklist for reference: > > > > [ ] Download links are valid. > > [ ] Checksums and signatures. > > [ ] LICENSE/NOTICE files exist > > [ ] No unexpected binary files > > [ ] All source files have ASF headers > > [ ] Can compile from source > > > > More detailed checklist please refer to: > > https://github.com/apache/iceberg-rust/tree/main/scripts > > > > To compile from source, please refer to: > > https://github.com/apache/iceberg-rust/blob/main/CONTRIBUTING.md > > > > Here is a Python script in release to help you verify the release > candidate: > > > > ./scripts/verify.py > > > > Thank you! >
