Hi Ryan, Thanks. I think the confusion is about what you describe like "contributions and reviews", reading the page:
" .. * Has the candidate made independent material contributions to the community that show expertise? ... * Have the candidate’s contributions been stable and maintainable? ... " etc It sounds like "code contributions and code reviews". I think it's what Justin meant. Regards JB On Wed, Dec 11, 2024 at 6:34 PM rdb...@gmail.com <rdb...@gmail.com> wrote: > > I want to make a clarification. I did comment on that PR that we are > describing how the community is operating today, but that was in response to > suggestions to reference the comdev project, lower the requirements, and add > a requirement for loving the project and helping the community. My intent is > to say that we're open to discussion, but that I want to make sure we get the > guidelines published before we make changes. > > I was NOT saying that we don't value non-code contributions today. We do, and > we made sure that the doc doesn't talk about only code. It refers to > contributions and reviews, not code. > > Ryan > > On Wed, Dec 11, 2024 at 12:21 AM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: >> >> Hi Justin >> >> For reference, here's the original PR: >> https://github.com/apache/iceberg/pull/11670 >> >> I agree with you, and I commented in the PR about the same points: >> - considering non code contributions (also referring com dev page >> https://community.apache.org/pmc/adding-committers.html as "example") >> - considering same criteria across the project (between iceberg-java, >> iceberg-python, iceberg-go, iceberg-rust, ...) because a committer/PMC >> member is for the whole project (not only on one module) >> >> Ryan and Fokko reassured me: they want to describe how the PMC is >> "operating" today, but they will certainly consider our comments in >> the future (and update the page). >> >> Regards >> JB >> >> On Wed, Dec 11, 2024 at 12:10 AM Justin Mclean <jus...@classsoftware.com> >> wrote: >> > >> > Hi, >> > >> > From a quick glance, this seems far too focused on code contributions. >> > Remember, people can become committers from non-code contributions. A >> > committer is someone that is committed to the project and may not review >> > or write code. It would also be good to set some expectations around the >> > amount of activity needed to become a committer rather than saying there >> > are none. >> > >> > Kind Regards, >> > Justin
