Thanks Sung. I assumed grep.app will continuously index all GitHub repos but it seems to be missing a few.
For completeness, I went through the GitHub search feature, using `org:apache` with both `upload-artifact@v3` and `download-artifact@v3`. * https://github.com/search?q=org%3Aapache%20upload-artifact%40v3&type=code * https://github.com/search?q=org%3Aapache+download-artifact%40v3&type=code Looks like `iceberg-rust` is the only place we missed. Best, Kevin Liu On Wed, Nov 27, 2024 at 5:45 AM Sung Yun <sun...@apache.org> wrote: > Hi JB and Kevin, thank you for jumping on the chore. > > Here's one more PR to bump up the version in iceberg-rust: > https://github.com/apache/iceberg-rust/pull/725 > > I assume this didn't show up in the grep.app search since it was recently > merged > > On 2024/11/26 22:22:36 Kevin Liu wrote: > > We merged the PR[1] to upgrade `upload-artifact` to V4. Thanks, Fokko for > > the review. > > > > Best, > > Kevin Liu > > > > [1] https://github.com/apache/iceberg-python/pull/1371 > > > > > > On Mon, Nov 25, 2024 at 10:36 PM Jean-Baptiste Onofré <j...@nanthrax.net> > > wrote: > > > > > Hi Kevin > > > > > > I did a quick search and I have the same feedback as you: only > > > iceberg-python is impacted. > > > > > > Thanks for the PR ! > > > > > > Regards > > > JB > > > > > > On Mon, Nov 25, 2024 at 9:03 PM Kevin Liu <kevinjq...@apache.org> > wrote: > > > > > > > > Hey folks, > > > > > > > > I did a code search for both `actions/upload-artifact` and > > > `actions/download-artifact` in the related iceberg repos. > > > > * > > > > https://grep.app/search?q=actions/upload-artifact%40v3&filter[repo.pattern][0]=apache/iceberg > > > > * > > > > https://grep.app/search?q=actions/download-artifact&filter[repo.pattern][0]=apache/iceberg > > > > > > > > Only iceberg-python is affected. Here's the PR to update the relevant > > > action, https://github.com/apache/iceberg-python/pull/1371 > > > > > > > > Best, > > > > Kevin Liu > > > > > > > > On Mon, Nov 25, 2024 at 10:36 AM Jacob Wujciak < > assignu...@apache.org> > > > wrote: > > > >> > > > >> Hello Everyone! > > > >> > > > >> I am writing to inform you of the imminent removal of the v3 > artifact > > > >> actions that was announced in [1]. Both actions/upload-artifact@v3* > > > >> and actions/download-artifact@v3* will stop working in 10 days, on > > > >> December 5, 2024! According to a quick code search this project is > > > >> using one of the actions with a v3 tag in at least one of its repos. > > > >> > > > >> There are breaking changes in the usage of the upload action that > will > > > >> likely require changes other than bumping the version, please see > [2]. > > > >> Make sure to update your workflows in time to avoid disruptions! > > > >> > > > >> If you have any questions or need help with the transition I'd > > > >> recommend bui...@apache.org as the place to look for help. > > > >> > > > >> Regards > > > >> Jacob Wujciak-Jens (assignUser) > > > >> > > > >> [1]: > > > > https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ > > > >> [2]: > > > https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md > > > > > >
