It's actually what I meant by REST Catalog docker image for test. Personally, I would not include any docker images in the Iceberg project (but more in the "iceberg" ecosystem, which is different from the project :)).
However, if the community has a different view on that, no problem. Regards JB On Thu, Oct 10, 2024 at 9:50 AM Daniel Weeks <dwe...@apache.org> wrote: > I think we should focus on the docker image for the test REST Catalog > implementation. This is somewhat different from the TCK since it's used by > the python/rust/go projects for testing the client side of the REST > specification. > > As for the quickstart/example type images, I'm open to discussing what > makes sense here, but we should decouple that and other docker images from > getting a test REST catalog image out. (Seems like there's general > consensus around that). > > -Dan > > On Thu, Oct 10, 2024 at 4:29 AM Ajantha Bhat <ajanthab...@gmail.com> > wrote: > >> Yes, the PRs I mentioned are about running TCK as a docker container and >> keeping/maintaining that docker file in the Iceberg repo. >> >> I envisioned maintaining other docker images also because I am not sure >> about the roadmap of the ones in our quickstart >> <https://iceberg.apache.org/spark-quickstart/> (example: >> tabulario/spark-iceberg). >> >> Thanks, >> Ajantha >> >> On Thu, Oct 10, 2024 at 3:50 PM Jean-Baptiste Onofré <j...@nanthrax.net> >> wrote: >> >>> Hi >>> >>> I think there's context missing here. >>> >>> I agree with Ryan that Iceberg should not provide any docker image or >>> runtime things (we had the same discussion about REST server). >>> >>> However, my understanding is that this discussion is also related to the >>> REST TCK. The TCK validation run needs a runtime, and I remember a >>> discussion we had with Daniel (running TCK as a docker container). >>> >>> Regards >>> JB >>> >>> On Wed, Oct 9, 2024 at 2:20 PM rdb...@gmail.com <rdb...@gmail.com> >>> wrote: >>> >>>> I think it's important for a project to remain focused on its core >>>> purpose, and I've always advocated for Iceberg to remain a library that is >>>> easy to plug into other projects. I think that should be the guide here as >>>> well. Aren't projects like Spark and Trino responsible for producing easy >>>> to use Docker images of those environments? Why would the Iceberg project >>>> build and maintain them? >>>> >>>> I would prefer not to be distracted by these things, unless we need >>>> them for cases like supporting testing and validation of things that are >>>> part of the core purpose of the project. >>>> >>>> On Tue, Oct 8, 2024 at 6:08 AM Ajantha Bhat <ajanthab...@gmail.com> >>>> wrote: >>>> >>>>> Hello everyone, >>>>> >>>>> Now that the test fixtures are in [1],we can create a runtime JAR for >>>>> the REST catalog adapter [2] from the TCK. >>>>> Following that, we can build and maintain the Docker image based on it >>>>> [3]. >>>>> >>>>> I also envision the Iceberg community maintaining some quick-start >>>>> Docker images, such as spark-iceberg-rest, Trino-iceberg-rest, among >>>>> others. >>>>> >>>>> I've looked into other Apache projects, and it seems that Apache Infra >>>>> can assist us with this process. >>>>> As we have the option to publish Iceberg docker images under the >>>>> Apache Docker Hub account. >>>>> >>>>> [image: image.png] >>>>> >>>>> I am more than willing to maintain this code, please find the PRs >>>>> related to the same [2] & [3]. >>>>> >>>>> Any suggestions on the same? contributions are welcome if we agree to >>>>> maintain it. >>>>> >>>>> [1] https://github.com/apache/iceberg/pull/10908 >>>>> [2] https://github.com/apache/iceberg/pull/11279 >>>>> [3] https://github.com/apache/iceberg/pull/11283 >>>>> >>>>> - Ajantha >>>>> >>>>
