Thanks Rahil for driving this and everyone for reviewing! Merged the PR. Thanks,
Amogh Jahagirdar On Tue, Sep 10, 2024 at 8:24 AM Chertara, Rahil <rcher...@amazon.com.invalid> wrote: > Thanks all for reviewing the pr. With 4 binding and 1 non-binding votes, > the vote has passed. Can a maintainer please merge the pr when they get a > chance? > > > > Thanks, > > Rahil Chertara > > > > *From: *Daniel Weeks <dwe...@apache.org> > *Reply-To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org> > *Date: *Thursday, September 5, 2024 at 8:59 AM > *To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org> > *Subject: *RE: [EXTERNAL] [VOTE] Merge REST Spec Change To Add New Scan > Planning APIs > > > > *CAUTION*: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > > +1 (binding) > > > > On Tue, Sep 3, 2024 at 1:22 PM rdb...@gmail.com <rdb...@gmail.com> wrote: > > +1 > > > > I think it would be good to give an overview of the current proposal since > it has evolved quite a bit from the original like Jack said. > > > > On Tue, Sep 3, 2024 at 9:09 AM Jack Ye <yezhao...@gmail.com> wrote: > > Thanks for keeping pushing for this Rahil. Personally I am +1 (binding) > for this, with just some minor comments in the latest PR. > > > > But I think the initial DISCUSS thread [1] was quite a while ago and a lot > has changed after a lot of comments and reviews. Should we restart another > DISCUSS thread before voting, to make sure people are aware of the latest > design and address any additional comments? > > > > Best, > > Jack Ye > > > > [1] https://lists.apache.org/thread/qq13468x6gk0vxnsckzc5xd02tjlvpkm > > > > > > On Mon, Sep 2, 2024 at 9:22 PM Chertara, Rahil <rcher...@amazon.com.invalid> > wrote: > > Hi all, > > > > I've opened a PR [1] to add REST spec changes for a new protocol around > table scan planning. For context around the design discussions, see the > original google doc proposal [2], the dev list discussion thread [3], and > finally the discussion that has happened on the spec change PR. > > > > Please vote on merging this change. The vote will remain open for at least > 72 hours. > > > > [] +1 > > [] +0 > > [] -1, do not merge because ... > > > > [1] https://github.com/apache/iceberg/pull/9695 > > [2] > https://docs.google.com/document/d/1FdjCnFZM1fNtgyb9-v9fU4FwOX4An-pqEwSaJe8RgUg/edit#heading=h.cftjlkb2wh4h > > [3] https://lists.apache.org/thread/qq13468x6gk0vxnsckzc5xd02tjlvpkm > > > > Thanks, > > Rahil Chertara > >
