>
> It’s not OK to include the gradle wrapper in the source release. A source
> release can't include any jars with compiled code in them.


Just to clarify that we're currently not adding the gradle wrapper in the
source distribution. We have some custom code
<https://github.com/apache/iceberg/blob/7477f8bfbcf9cded7129bbf8ca7e91bcaa81c1ae/gradlew#L89-L91>
for that exact reason that downloads the gradle wrapper if it's missing
when running `./gradlew build`.



On Tue, Aug 20, 2024 at 11:56 PM Justin Mclean <jus...@classsoftware.com>
wrote:

> Hi,
>
> > I would add an additional check on the source distribution: the source
> > distribution should not contain any unexpected binary file (gradle
> > wrapper is OK, but other binary should be avoided).
>
> It’s not OK to include the gradle wrapper in the source release. A source
> release can't include any jars with compiled code in them.
>
> Kind Regards,
> Justin

Reply via email to