Thanks a lot for the verification. I will try to improve this part to make our verification process much easier.
On Mon, Aug 19, 2024, at 09:56, Renjie Liu wrote: > +1 for updating the verify script to run make test, or should we just ask > users to run `make test` without the scripts? > > On Mon, Aug 19, 2024 at 1:04 AM Amogh Jahagirdar <2am...@gmail.com> wrote: >> +1 (binding) >> >> I verified checksum/signatures/license/notice/no unexpected binary files/ASF >> headers. I also ran make test. >> >> Also it seems like the Iceberg rust project has a verify script which does a >> build >> <https://github.com/apache/iceberg-rust/blob/main/scripts/verify.py#L39>, >> and then users have to explicitly run tests via make. Should we update the >> verify script to run tests by default since I'd imagine most users want to >> run tests by default as part of release verification? Do let me know if I'm >> missing something. >> >> Thanks, >> Amogh Jahagirdar >> >> On Sat, Aug 17, 2024 at 7:24 AM Renjie Liu <liurenjie2...@gmail.com> wrote: >>> Hi: >>> >>> Kindly reminder that we still need 2 binding votes. Please help to verify. >>> >>> On Wed, Aug 14, 2024 at 23:56 Xuanwo <xua...@apache.org> wrote: >>>> Hello, Apache Iceberg Rust Community, >>>> >>>> This is a call for a vote to release Apache Iceberg rust version 0.3.0. >>>> >>>> The tag to be voted on is 0.3.0. >>>> >>>> The release candidate: >>>> >>>> https://dist.apache.org/repos/dist/dev/iceberg/iceberg-rust-0.3.0-rc.1/ >>>> >>>> Keys to verify the release candidate: >>>> >>>> https://downloads.apache.org/iceberg/KEYS >>>> >>>> Git tag for the release: >>>> >>>> https://github.com/apache/iceberg-rust/releases/tag/v0.3.0-rc.1 >>>> >>>> Please download, verify, and test. >>>> >>>> The VOTE will be open for at least 72 hours and until the necessary >>>> number of votes are reached. >>>> >>>> [ ] +1 approve >>>> [ ] +0 no opinion >>>> [ ] -1 disapprove with the reason >>>> >>>> To learn more about Apache Iceberg Rust, please see >>>> https://rust.iceberg.apache.org/ >>>> >>>> Checklist for reference: >>>> >>>> [ ] Download links are valid. >>>> [ ] Checksums and signatures. >>>> [ ] LICENSE/NOTICE files exist >>>> [ ] No unexpected binary files >>>> [ ] All source files have ASF headers >>>> [ ] Can compile from source >>>> >>>> More detailed checklist please refer to: >>>> https://github.com/apache/iceberg-rust/tree/main/scripts >>>> >>>> To compile from source, please refer to: >>>> https://github.com/apache/iceberg-rust/blob/main/CONTRIBUTING.md >>>> >>>> Here is a Python script in release to help you verify the release >>>> candidate: >>>> >>>> ./scripts/verify.py >>>> >>>> Thanks >>>> >>>> Xuanwo >>>> >>>> https://xuanwo.io/ Xuanwo https://xuanwo.io/
