Thanks Micah and all who voted! I merged the change. Thanks,
Amogh Jahagirdar On Mon, Aug 5, 2024 at 6:49 PM Micah Kornfield <emkornfi...@gmail.com> wrote: > The vote passes with: > > 3 +1 binding votes (Yufei, Daniel, Ryan) > 2 +1 non-binding votes (Micah, Prashant). > > Action items: merge the change. Could a committer/PMC member help with > this? > > Thanks, > Micah > > On Mon, Aug 5, 2024 at 8:14 AM Daniel Weeks <dwe...@apache.org> wrote: > >> +1 (binding) >> >> On Fri, Aug 2, 2024 at 1:25 PM Ryan Blue <b...@databricks.com.invalid> >> wrote: >> >>> +1 (binding) >>> >>> On Fri, Aug 2, 2024 at 12:03 PM Yufei Gu <flyrain...@gmail.com> wrote: >>> >>>> +1 (binding) >>>> Yufei >>>> >>>> >>>> On Fri, Aug 2, 2024 at 11:18 AM Prashant Singh < >>>> prashant010...@gmail.com> wrote: >>>> >>>>> +1 (non-binding) >>>>> Thanks Micah ! >>>>> >>>>> Regards, >>>>> Prashant >>>>> >>>>> On Fri, Aug 2, 2024 at 11:06 AM Micah Kornfield <emkornfi...@gmail.com> >>>>> wrote: >>>>> >>>>>> I've opened a PR [1] to clarify that partition columns must always be >>>>>> written by implementations and that for identity transformed partition >>>>>> values, the metadata from the manifest file must be used. >>>>>> >>>>>> Please vote on merging this change. The vote will remain open for at >>>>>> least 72 hours. >>>>>> >>>>>> [] +1 >>>>>> [] +0 >>>>>> [] -1, do not merge because ... >>>>>> >>>>>> My vote is +1 >>>>>> >>>>>> Thanks, >>>>>> Micah >>>>>> >>>>>> >>>>>> [1] https://github.com/apache/iceberg/pull/10835 >>>>>> >>>>> >>> >>> -- >>> Ryan Blue >>> Databricks >>> >>
