Hi, Thanks for additional feedback. It sounds like we're OK enabling builds and testing with JDK 21 with the caveats that formatter is off. The non-negotiable condition is that CI still checks format. I think this is exactly what this PR <https://github.com/apache/iceberg/pull/10474> is doing, which means we maybe can merge it. One small step forward.
BTW there is no risk of `./gradlew spotlessApply` producing different results when being executed under JDK 21. The spotless plugin needs to be fully disabled, and then this command will fail saying the target is not found. It would be even better to provide custom spotlessApply command stub that would produce an actionable error message. I will add something like this to the above PR. re dropping Java 8 we need to figure out exact deprecation path and I don't know yet the customs to drive this fully. But happy to help as much as I can nonetheless. Best Piotr On Wed, 10 Jul 2024 at 11:19, Eduard Tudenhöfner <etudenhoef...@apache.org> wrote: > >> It has a caveat (we can't run formatter on 21 and 8, and we need to >>> choose one). >> >> >> Would it format differently? I would go for 21 since that's the path >> forward, but I'm also fine with JB's suggestion 👍 >> >>> >>> > Yeah it would format differently, because the underlying > *google-java-format* picks a different formatting depending on the JDK > version and that's why we had to pin the *google-java-format* version to > the one that still supports JDK8. > > I think it's ok to disable the formatter when running with JDK 21 for > people that want to use that JDK but we need to make sure that CI checks > still run JDK < 21 in order to make sure code is properly formatted. > > The one risk I see is that it will be difficult to understand why running > the build with JDK 21 passes locally but fails on CI (where an older JDK is > used). > Maybe it's sufficient to mention in the docs that *./gradlew > spotlessApply* needs to be executed locally with an older JDK. > > Eduard >
