Thanks everyone for voting! Thanks Dan for reporting the issue and Fokko for the context! Let's do another RC to include the https://github.com/apache/iceberg-python/pull/615.
Some additional note: In our case, this issue only affects the release dist because it does not contain the poetry.lock file. Running "make install" on the repo cloned from github will not hit the issue because poetry.lock specifies docutil version to be 0.20.1 <https://github.com/apache/iceberg-python/blob/59cd69c66b17c402cf33f6accd8d32c94419702f/poetry.lock#L908> . Best regards, Honah On Wed, Apr 17, 2024 at 11:07 PM Fokko Driesprong <fo...@apache.org> wrote: > Thanks everyone for voting. And Dan, thanks for reporting the issue. I > went down the rabbit hole 🐇 It is being tracked here > <https://github.com/pypi/warehouse/issues/15749>, and a fix is inbound > here <https://github.com/pypi/warehouse/pull/15795/>. This issue should > fix itself because the version containing post1 was released on the 9th of > April, and a follow-up was done on the 10th > <https://pypi.org/project/docutils/0.21.1/#history>. Locally I have > installed an older version because the docutils>0.20.1 requires Python 3.9 > or later, and I'm still on 3.8: > > poetry show docutils > name : docutils > version : 0.20.1 > description : Docutils -- Python Documentation Utilities > > required by > - pytest-checkdocs >=0.15 > > As you can see it is luckily only being used by a dev-dependency. I'm able > to reproduce it locally using Python 3.10 (using Docker), and also tried > the workaround in the issue, and that fixes the problem > <https://github.com/python-poetry/poetry/issues/9293#issuecomment-2048205226>. > Another option is to exclude the bodged version of docutils explicitly, and > this will cause the resolved to skip it entirely: > https://github.com/apache/iceberg-python/pull/615 I think this is a good > workaround until the patch is being released. It is not likely that we run > into this again since only 0.004% of the releases have this post notation > in the filename that causes issue :) WDYT? > > Kevin, looking at your error, that seems to be a different issue where pip > cannot be found. I would also not recommend to use poetry inside of a venv. > Poetry provides similar functionality to venv (poetry shell). Another thing > to take into consideration is that checking out the Github tag is different > than extracting the .tar.gz. On Github there is the poetry.lock file that > provides reproducable CI builds, and this is missing from the tar.gz (where > it will try to install the latest and greatest). > > Kind regards, > Fokko Driesprong > > > Op do 18 apr 2024 om 04:21 schreef Kevin Liu <kevin.jq....@gmail.com>: > >> +1 (non binding) >> >> Downloaded specific commit from the repo, and ran both the Python tests >> and integration tests. >> >> Steps: >> ``` >> git clone --depth=1 --branch pyiceberg-0.6.1rc2 g...@github.com: >> apache/iceberg-python.git >> python -m venv ./venv >> source ./venv/bin/activate >> make install >> make test >> make test-integration >> ``` >> >> Also ran into the issue Dan mentioned, subsequent `make install` ran >> successfully. Here's the stack trace: >> ``` >> Preparing build environment with build-system requirements >> poetry-core>=1.0.0, wheel, Cython>=3.0.0, setuptools >> Command >> ['/var/folders/f1/3_vzsn7x1jq9hszb3z9y6f0m0000gn/T/tmph283p6rj/.venv/bin/python', >> '/private/tmp/iceberg-python/venv/lib/python3.11/site-packages/virtualenv/seed/wheels/embed/pip-24.0-py3-none-any.whl/pip', >> 'install', '--disable-pip-version-check', '--ignore-installed', >> '--no-input', 'poetry-core>=1.0.0', 'wheel', 'Cython>=3.0.0', 'setuptools'] >> errored with the following return code 2 >> >> Output: >> /var/folders/f1/3_vzsn7x1jq9hszb3z9y6f0m0000gn/T/tmph283p6rj/.venv/bin/python: >> can't open file >> '/private/tmp/iceberg-python/venv/lib/python3.11/site-packages/virtualenv/seed/wheels/embed/pip-24.0-py3-none-any.whl/pip': >> [Errno 2] No such file or directory >> >> make: *** [install-dependencies] Error 1 >> ``` >> >> Thanks, >> Kevin >> >> On Wed, Apr 17, 2024 at 3:06 PM Daniel Weeks <dwe...@apache.org> wrote: >> >>> I tried running the verification process but ran into issues resolving >>> some of the dependencies: >>> >>> make install >>> Updating dependencies >>> Resolving dependencies... (3.1s) >>> >>> Package docutils (0.21.post1) not found. >>> make: *** [install-dependencies] Error 1 >>> >>> I found this related issue >>> <https://github.com/python-poetry/poetry/issues/9293#issuecomment-2048205226> >>> which indicates pip is trying to install a "post release" version. >>> >>> This was with python 3.10 and pip 22.0.4 >>> >>> I haven't been able to get the install to properly resolve the >>> dependencies >>> >>> -Dan >>> >>> >>> On Wed, Apr 17, 2024 at 2:10 PM Jean-Baptiste Onofré <j...@nanthrax.net> >>> wrote: >>> >>>> +1 (non binding) >>>> >>>> I checked: >>>> - Hash and signature are good >>>> - LICENSE and NOTICE look good >>>> - No binary file found in the source distribution >>>> - Ran a few tests >>>> >>>> Regards >>>> JB >>>> >>>> On Tue, Apr 16, 2024 at 4:53 AM Honah J. <hon...@apache.org> wrote: >>>> > >>>> > Hi Everyone, >>>> > >>>> > I propose that we release the following RC as the official PyIceberg >>>> 0.6.1 release. >>>> > >>>> > This is a patch release due to the following bugs: >>>> > >>>> > Fail to create version 1 table with non-empty partition-spec and >>>> sort-order >>>> > Hive Catalog cannot create table with TimestamptzType field >>>> > Fail to read parquet file with special characters in column names >>>> > Hive Catalog commit consistency issue >>>> > >>>> > Smaller bugs also have been backported. >>>> > >>>> > The commit ID is 0161e5c6b9bea2b6cf47245efd8df85da2c3d9b0 >>>> > >>>> > * This corresponds to the tag: pyiceberg-0.6.1rc2 >>>> (139fdff1ff6cff97264a61db8e9ed9ee3520d6d2) >>>> > * >>>> https://github.com/apache/iceberg-python/releases/tag/pyiceberg-0.6.1rc2 >>>> > * >>>> https://github.com/apache/iceberg-python/tree/0161e5c6b9bea2b6cf47245efd8df85da2c3d9b0 >>>> > >>>> > The release tarball, signature, and checksums are here: >>>> > >>>> > * https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.6.1rc2/ >>>> > >>>> > You can find the KEYS file here: >>>> > >>>> > * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>> > >>>> > Convenience binary artifacts are staged on pypi: >>>> > >>>> > https://pypi.org/project/pyiceberg/0.6.1rc2/ >>>> > >>>> > And can be installed using: pip3 install pyiceberg==0.6.1rc2 >>>> > >>>> > Please download, verify, and test. >>>> > >>>> > Please vote in the next 72 hours. >>>> > [ ] +1 Release this as PyIceberg 0.6.1 >>>> > [ ] +0 >>>> > [ ] -1 Do not release this because... >>>> >>>
