+1 (binding) Verified all the usual things Ran full test suite Everything looking good
> On Mar 8, 2024, at 11:35 PM, Szehon Ho <szehon.apa...@gmail.com> wrote: > > +1 (binding) > > * Verified signature > * Verified checksum > * RAT check > * built JDK 11 > * Ran basic tests on Spark 3.5 > > Thanks > Szehon > > On Fri, Mar 8, 2024 at 5:50 PM Amogh Jahagirdar <am...@tabular.io > <mailto:am...@tabular.io>> wrote: >> +1 non-binding >> >> Verified signatures,checksums,RAT checks, build, and tests with JDK11. I >> also ran ad-hoc tests for views in Trino with the rest catalog. >> >> Thanks, >> >> Amogh Jahagirdar >> >> On Fri, Mar 8, 2024 at 5:04 PM Ryan Blue <b...@tabular.io >> <mailto:b...@tabular.io>> wrote: >>> +1 (binding) >>> >>> - Normal tarball verification >>> - Read from my broken view successfully >>> >>> On Fri, Mar 8, 2024 at 3:07 PM Daniel Weeks <dwe...@apache.org >>> <mailto:dwe...@apache.org>> wrote: >>>> +1 (binding) >>>> >>>> Verified sigs/sums/license/build/tests (Java 17) >>>> >>>> -Dan >>>> >>>> On Thu, Mar 7, 2024 at 2:10 PM Hussein Awala <huss...@awala.fr >>>> <mailto:huss...@awala.fr>> wrote: >>>>> +1 (non-binding) >>>>> - checked checksum and signature >>>>> - built from source with jdk11 >>>>> - tested read and write with Spark 3.5.1 and Glue catalog >>>>> >>>>> All looks good >>>>> >>>>> On Thu, Mar 7, 2024 at 10:49 PM Drew <img...@gmail.com >>>>> <mailto:img...@gmail.com>> wrote: >>>>>> +1 (non-binding) >>>>>> >>>>>> - verified signature and checksum >>>>>> - verified RAT license check >>>>>> - verified build/tests passing with JDK17 >>>>>> - ran some manual tests on Spark3.5 with GlueCatalog >>>>>> >>>>>> Drew >>>>>> >>>>>> On Thu, Mar 7, 2024 at 4:38 AM Ajantha Bhat <ajanthab...@gmail.com >>>>>> <mailto:ajanthab...@gmail.com>> wrote: >>>>>>> +1 (non-binding) >>>>>>> >>>>>>> * validated checksum and signature >>>>>>> * checked license docs & ran RAT checks >>>>>>> * ran build and tests with JDK11 >>>>>>> * verified view support for Nessie catalog with Spark 3.5. >>>>>>> * verified this RC against Trino >>>>>>> (https://github.com/trinodb/trino/pull/20957) >>>>>>> >>>>>>> - Ajantha >>>>>>> >>>>>>> >>>>>>> On Wed, Mar 6, 2024 at 7:25 PM Jean-Baptiste Onofré <j...@nanthrax.net >>>>>>> <mailto:j...@nanthrax.net>> wrote: >>>>>>>> +1 (non binding) >>>>>>>> >>>>>>>> - checksums and signatures are OK >>>>>>>> - ASF headers are present >>>>>>>> - No unexpected binary files in the source distribution >>>>>>>> - Build OK with JDK11 >>>>>>>> - JdbcCatalog tested on Trino and Iceland >>>>>>>> - No unexpected artifact distributed >>>>>>>> >>>>>>>> Thanks ! >>>>>>>> >>>>>>>> Regards >>>>>>>> JB >>>>>>>> >>>>>>>> On Wed, Mar 6, 2024 at 12:04 AM Ajantha Bhat <ajanthab...@gmail.com >>>>>>>> <mailto:ajanthab...@gmail.com>> wrote: >>>>>>>> > >>>>>>>> > Hi Everyone, >>>>>>>> > >>>>>>>> > I propose that we release the following RC as the official Apache >>>>>>>> > Iceberg 1.5.0 release. >>>>>>>> > >>>>>>>> > The commit ID is 2519ab43d654927802cc02e19c917ce90e8e0265 >>>>>>>> > * This corresponds to the tag: apache-iceberg-1.5.0-rc6 >>>>>>>> > * https://github.com/apache/iceberg/commits/apache-iceberg-1.5.0-rc6 >>>>>>>> > * >>>>>>>> > https://github.com/apache/iceberg/tree/2519ab43d654927802cc02e19c917ce90e8e0265 >>>>>>>> > >>>>>>>> > The release tarball, signature, and checksums are here: >>>>>>>> > * >>>>>>>> > https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.5.0-rc6 >>>>>>>> > >>>>>>>> > You can find the KEYS file here: >>>>>>>> > * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>>>>>> > >>>>>>>> > Convenience binary artifacts are staged on Nexus. The Maven >>>>>>>> > repository URL is: >>>>>>>> > * >>>>>>>> > https://repository.apache.org/content/repositories/orgapacheiceberg-1161/ >>>>>>>> > >>>>>>>> > Please download, verify, and test. >>>>>>>> > >>>>>>>> > Please vote in the next 72 hours. >>>>>>>> > >>>>>>>> > [ ] +1 Release this as Apache Iceberg 1.5.0 >>>>>>>> > [ ] +0 >>>>>>>> > [ ] -1 Do not release this because... >>>>>>>> > >>>>>>>> > Only PMC members have binding votes, but other community members are >>>>>>>> > encouraged to cast >>>>>>>> > non-binding votes. This vote will pass if there are 3 binding +1 >>>>>>>> > votes and more binding >>>>>>>> > +1 votes than -1 votes. >>>>>>>> > >>>>>>>> > - Ajantha >>> >>> >>> -- >>> Ryan Blue >>> Tabular