https://github.com/apache/iceberg/pull/8970
> On Oct 28, 2023, at 12:26 PM, Ryan Blue <[email protected]> wrote: > > I also noticed recently that the equality field IDs were exposed when they > shouldn't be in the builder. I'm all for removing it in 2.0 and throwing an > exception if anyone tries to set them. That was the original intent. > > On Fri, Oct 27, 2023 at 12:29 PM Anton Okolnychyi > <[email protected]> wrote: >> Hey folks, >> >> I see that our Java implementation does not follow the spec when it comes to >> storing equality field IDs. The spec says that column is for equality >> deletes only. However, our builder for DataFile allows setting and >> persisting that field in the metadata. To make things worse, the action for >> rewriting manifests would drop that field for data files even if it was >> persisted initially. >> >> Do we see value in this field for data files or shall we fix the >> implementation to follow the spec? We already annotate each snapshot with a >> set of equality IDs. Are there use cases where it is not enough for data >> files? If not, I’d rather disallow setting it. >> >> - Anton > > > -- > Ryan Blue > Tabular
