+1 (non-binding) - validated checksum and signature - checked license docs & ran RAT checks - ran build and tests with JDK11
Thanks, Ajantha On Tue, Oct 31, 2023 at 6:32 AM Amogh Jahagirdar <am...@tabular.io> wrote: > +1 non-binding > > 1.) Validated checksum and signature > 2.) RAT/license checks > 3.) Build/tests with JDK8 > 4.) Performed an ad-hoc Spark test which would read a table with corrupted > offsets and verified it succeeded to verify that the new patch works end to > end. > > Thanks, > > Amogh Jahagirdar > > On Mon, Oct 30, 2023 at 11:20 AM Hussein Awala <huss...@awala.fr> wrote: > >> +1 (non-binding) I tested the RC with spark 3.3 and hive catalog. All >> looks good. >> >> >> On Mon 30 Oct 2023 at 16:48, Eduard Tudenhoefner <edu...@tabular.io> >> wrote: >> >>> +1 (non-binding) >>> >>> * validated checksum and signature >>> * checked license >>> * ran build and tests with JDK11 >>> >>> On Sat, Oct 28, 2023 at 11:09 PM Amogh Jahagirdar <am...@tabular.io> >>> wrote: >>> >>>> Hi Everyone, >>>> >>>> I propose that we release the following RC as the official Apache >>>> Iceberg 1.4.2 release. >>>> >>>> The commit ID is f6bb9173b13424d77e7ad8439b5ef9627e530cb2 >>>> * This corresponds to the tag: apache-iceberg-1.4.2-rc0 >>>> * https://github.com/apache/iceberg/commits/apache-iceberg-1.4.2-rc0 >>>> * >>>> https://github.com/apache/iceberg/tree/f6bb9173b13424d77e7ad8439b5ef9627e530cb2 >>>> >>>> The release tarball, signature, and checksums are here: >>>> * >>>> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.4.2-rc0 >>>> >>>> You can find the KEYS file here: >>>> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>> >>>> Convenience binary artifacts are staged on Nexus. The Maven repository >>>> URL is: >>>> * https://repository.apache.org/ >>>> <https://repository.apache.org/content/repositories/orgapacheiceberg-1148/> >>>> content/repositories/ >>>> <https://repository.apache.org/content/repositories/orgapacheiceberg-1148/>org >>>> apache iceberg-1148 >>>> <https://repository.apache.org/content/repositories/orgapacheiceberg-1148/> >>>> >>>> This release includes a patch for ensuring engines can successfully >>>> read tables when their split offset metadata was corrupted due to a bug in >>>> 1.4.0. See https://github.com/apache/iceberg/pull/8925 for more >>>> details. >>>> >>>> Please download, verify, and test. >>>> >>>> Please vote in the next 72 hours. >>>> [ ] +1 Release this as Apache Iceberg 1.4.2 >>>> [ ] +0 >>>> [ ] -1 Do not release this because... >>>> >>>> Only PMC members have binding votes, but other community members are >>>> encouraged to cast >>>> non-binding votes. This vote will pass if there are 3 binding +1 votes >>>> and more binding >>>> +1 votes than -1 votes. >>>> >>>