I think nesting in struct makes sense to support as this is consistent with partitioning input columns.
I can propose a PR if there aren't any more opinions here. On Fri, Oct 20, 2023 at 3:49 PM Ryan Blue <b...@tabular.io> wrote: > You're right. It calls out that `float` and `double` columns can't be > used, but there's a question around what is "equal" for maps, at the least. > > I think the reasonable thing to do is to allow top-level fields and fields > that are nested within only struts. Any field nested within a map or list > should not be allowed. Similarly, I think we could handle fields with > primitive or struct types but fields that contain lists or maps should not > be allowed. > > Does that sound reasonable to you? We could be more conservative and > disallow deletion by struct fields as well. > > Ryan > > On Fri, Oct 20, 2023 at 1:40 PM Micah Kornfield <emkornfi...@gmail.com> > wrote: > >> Hi Iceberg Dev, >> Are equality delete files intended to support nested columns of nested >> types (lists, structs and maps) or "children" of nested types? I couldn't >> find anything prohibiting it in the specification [1] (apologies if I >> missed it) but it seems like this adds a fair amount of complexity and >> ambiguity if they are supported. >> >> Thanks, >> Micah >> >> [1] https://iceberg.apache.org/spec/ >> > > > -- > Ryan Blue > Tabular >
