-1 I went to verify the sha512 sum, but it is missing.
If we can add the correct checksum, then I'll update my vote. Looks like
the sha512 sum for the GPG signature file was added instead:
pyiceberg-0.5.0.tar.gz*.asc*.sha512
Everything else looks good.
- Ran license checks
- Verified signature
- Ran tests
On Thu, Sep 14, 2023 at 6:47 PM Xuanwo <xua...@apache.org> wrote:
> Hi,
>
> +1 (non-binding)
>
> I have checked:
>
> - signature that made by fo...@apache.org
>
> ```
> :) for name in $(ls /tmp/pyiceberg/pyiceberg-*.whl
> /tmp/pyiceberg/pyiceberg-*.tar.gz)
> do
> gpg --verify ${name}.asc ${name}
> done
> gpg: Signature made Wed 13 Sep 2023 08:07:40 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:40 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:40 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:40 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:41 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:41 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:41 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:41 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:38 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:39 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:39 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:39 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:39 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:39 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:40 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:40 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:42 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:42 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:42 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:42 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:43 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:43 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:41 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:42 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:42 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> gpg: Signature made Wed 13 Sep 2023 08:07:43 PM CST
> gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550
> gpg: issuer "fo...@apache.org"
> gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [ultimate]
> ```
>
> - licenses checked by RAT
>
> ```shell
> :) ./dev/check-license
> Attempting to fetch rat
> Ignored 0 lines in your exclusion files as comments or empty lines.
> RAT checks passed.
> ```
>
> On Fri, Sep 15, 2023, at 04:15, Fokko Driesprong wrote:
>
> Hey everyone,
>
> A small follow-up on how to easily run the checks:
> curl https://dist.apache.org/repos/dist/dev/iceberg/KEYS -o KEYS
> gpg --import KEYS
>
> svn checkout
> https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.5.0rc3/
> /tmp/pyiceberg/
>
> for name in $(ls /tmp/pyiceberg/pyiceberg-*.whl
> /tmp/pyiceberg/pyiceberg-*.tar.gz)
> do
> gpg --verify ${name}.asc ${name}
> done
>
> cd /tmp/pyiceberg/
> for name in $(ls /tmp/pyiceberg/pyiceberg-*.whl.asc.sha512
> /tmp/pyiceberg/pyiceberg-*.tar.gz.asc.sha512)
> do
> shasum -a 512 --check ${name}
> done
>
> tar xzf pyiceberg-0.5.0.tar.gz
> cd pyiceberg-0.5.0
>
> ./dev/check-license
>
> This will be part of the docs once released.
> Kind regards,
> Fokko
>
>
> Op wo 13 sep 2023 om 14:18 schreef Fokko Driesprong <fo...@apache.org>:
>
> Hi Everyone,
>
>
> I propose that we release the following RC as the official PyIceberg 0.5.0
> release. This includes the performance issue that was discovered in RC2. A
> summary of what's included in 0.5.0:
>
> - Add gzip metadata support
> <https://github.com/apache/iceberg/pull/7984>
> - PyArrow HDFS support <https://github.com/apache/iceberg/pull/7997>
> - Support serverless environments (AWS Lambda)
> <https://github.com/apache/iceberg/pull/8061>
> - Many fixes around Avro performance (PRs 1
> <https://github.com/apache/iceberg/pull/8074>, 2
> <https://github.com/apache/iceberg/pull/8075>, 3
> <https://github.com/apache/iceberg/pull/8082>, 4
> <https://github.com/apache/iceberg/pull/8084>)
> - Remove the upper bound of PyParsing dependency
> <https://github.com/apache/iceberg/pull/8116> (blocking a PR in Airflow
> <https://github.com/apache/airflow/pull/32786>)
> - Moving the reading of Avro to Cython
> <https://github.com/apache/iceberg/pull/8134> (10x speed
> improvement(!))
> - Support for the SQLCatalog
> <https://github.com/apache/iceberg/pull/7921> (JDBC in Java)
> - Fix support for UUID columns
> <https://github.com/apache/iceberg/pull/8267>
> - Support for adding columns
> <https://github.com/apache/iceberg/pull/8174>
> - Optimize concurrency <https://github.com/apache/iceberg/pull/8104>
> (follow
> up on the Support serverless environments)
> - Bump Pydantic to v2 <https://github.com/apache/iceberg/pull/7782>
> (improved
> performance of the JSON (de)serialization)
> - A lot of bugfixes!
>
> The commit ID is f798b06246e67131d413dfceece5ccaf269e01fe
>
>
>
> - This corresponds to the tag: pyiceberg-0.5.0rc3
> (37fa779b0957644590a03754a733a5b3e3f589d0)
> - https://github.com/apache/iceberg/releases/tag/pyiceberg-0.5.0rc3
> -
>
> https://github.com/apache/iceberg/tree/f798b06246e67131d413dfceece5ccaf269e01fe
>
>
> The release tarball, signature, and checksums are here:
>
>
>
> - https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.5.0rc3/
>
>
> You can find the KEYS file here:
>
>
>
> - https://dist.apache.org/repos/dist/dev/iceberg/KEYS
>
>
> Convenience binary artifacts are staged on pypi:
>
>
> https://pypi.org/project/pyiceberg/0.5.0rc3/
>
>
> And can be installed using: pip3 install pyiceberg==0.5.0rc3
>
>
> Please download, verify, and test.
>
>
> Please vote in the next 72 hours.
>
>
> [ ] +1 Release this as PyIceberg 0.5.0
>
> [ ] +0
>
> [ ] -1 Do not release this because...
>
>
> Cheers, Fokko
>
>
> Xuanwo
>
>
--
Ryan Blue
Tabular
