An update from my end. There is a PR ready to run the Avro decoder tests <https://github.com/apache/iceberg/pull/8532/> against the binary wheel. I'm able to reproduce the issue on my end, and after including the `.pyd` files I noticed that the tests failed <https://github.com/apache/iceberg/issues/8530#issuecomment-1712482320>. Rusty jumped in <https://github.com/apache/iceberg/issues/8530#issuecomment-1712493430> and we both learned that an unsigned long on Windows is 32bits. Once those are in, we're ready for another RC.
Cheers, Fokko Op za 9 sep 2023 om 09:48 schreef Fokko Driesprong <fo...@apache.org>: > Hey everyone, > > Thanks for casting the vote, appreciate it. I would like to cancel this > RC, and run RC2 which will include 3 PRs: > > - Python: Non-Cython fallback Avro parser > <https://github.com/apache/iceberg/pull/8521> > - Python: Fix pyarrow hdfs support > <https://github.com/apache/iceberg/pull/8524> > - Python: Issue with Windows cython build > <https://github.com/apache/iceberg/issues/8530> (still an issue, > working on a fix) > > While we don't officially support Windows (Anybody willing to add it to > the CI? :D), it is evident that support is broken with the new release, and > I think that we should fix that regression. If there is anything that you > want to include as well, please let me know. > > Cheers, > Fokko > > > Op za 9 sep 2023 om 09:37 schreef Jonas Jiang <jonasjiang....@gmail.com>: > >> +1 (non-binding) >> >> Verified signature, checksum, license using the updated steps >> Ran tests via "make test-coverage" >> Ran glue integration tests >> >> Best regards, >> Jonas >> >> On Fri, Sep 8, 2023 at 3:19 PM Hussein Awala <huss...@awala.fr> wrote: >> >>> +1 (non binding) I ran the example notebooks and tested some queries >>> with PyArrow and Pandas >>> >>> On Tue, Sep 5, 2023 at 9:21 PM Fokko Driesprong <fo...@apache.org> >>> wrote: >>> >>>> Hi everyone >>>> >>>> I propose that we release the following RC as the official PyIceberg >>>> 0.5.0 release. >>>> >>>> The commit ID is 5bd7c649e4743a61eace5f52517db9b5b56ff8e6 >>>> >>>> * This corresponds to the tag: pyiceberg-0.5.0rc1 ( >>>> 4f314fc507dec4ae918d3a3dfba567a28f92ac22) >>>> * https://github.com/apache/iceberg/releases/tag/pyiceberg-0.5.0rc1 >>>> * >>>> https://github.com/apache/iceberg/tree/5bd7c649e4743a61eace5f52517db9b5b56ff8e6 >>>> >>>> The release tarball, signature, and checksums are here: >>>> >>>> * https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.5.0rc1/ >>>> >>>> You can find the KEYS file here: >>>> >>>> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>> >>>> Convenience binary artifacts are staged on pypi: >>>> >>>> https://pypi.org/project/pyiceberg/0.5.0rc1/ >>>> >>>> And can be installed using: pip3 install pyiceberg==0.5.0rc1 >>>> >>>> Since a lot has changed due to the release of the wheels (binary Python >>>> libraries), I've included the following steps to verify the release >>>> <https://github.com/apache/iceberg/pull/8504>: >>>> >>>> curl https://dist.apache.org/repos/dist/dev/iceberg/KEYS -o KEYS >>>> gpg --import KEYS >>>> >>>> svn checkout >>>> https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.5.0rc1/ >>>> /tmp/pyiceberg/ >>>> >>>> for name in $(ls /tmp/pyiceberg/pyiceberg-*.whl >>>> /tmp/pyiceberg/pyiceberg-*.tar.gz) >>>> do >>>> gpg --verify ${name}.asc ${name} >>>> done >>>> >>>> cd /tmp/pyiceberg/ >>>> for name in $(ls /tmp/pyiceberg/pyiceberg-*.whl.asc.sha512 >>>> /tmp/pyiceberg/pyiceberg-*.tar.gz.asc.sha512) >>>> do >>>> shasum -a 512 --check ${name} >>>> done >>>> >>>> tar xzf pyiceberg-0.5.0.tar.gz >>>> cd pyiceberg-0.5.0 >>>> >>>> ./dev/check-license >>>> >>>> Please download, verify, and test. >>>> >>>> Please vote in the next 72 hours. >>>> [ ] +1 Release this as PyIceberg 0.5.0 >>>> [ ] +0 >>>> [ ] -1 Do not release this because... >>>> >>>> Consider this my +1 (binding), I've tested the license, and checksums >>>> and ran example notebooks against the 0.5.0 rc1 >>>> <https://github.com/tabular-io/docker-spark-iceberg/pull/92>. >>>> >>>> Cheers, Fokko >>>> >>>
