+1 (binding) 1. Verify signatures 2. Verify checksums 3. Verify license documentation 4. Built and ran tests, only failure is TestS3RestSigner 5. Ran simple queries against Spark 3.4
Thanks Szehon On Mon, Jul 24, 2023 at 11:58 AM Ryan Blue <b...@tabular.io> wrote: > +1 (binding) > > On Mon, Jul 24, 2023 at 10:44 AM Yufei Gu <flyrain...@gmail.com> wrote: > >> +1 (binding) >> >> Verified signature, checksum >> Verified License >> Built and ran tests >> Ran queries on Spark 3.3_2.12 >> >> The test TestS3RestSigner still failed locally for me like the version >> 1.3.0. As Edward mentioned, it's due to Docker on Mac not being able to >> resolve "localhost". Given this is a maintenance version, +1 for the >> release. >> >> Here is the stack of the failure. >> >> > Task :iceberg-aws:test FAILED >> >> TestS3RestSigner > validatePutObject FAILED >> software.amazon.awssdk.core.exception.SdkClientException: Received an >> UnknownHostException when attempting to interact with a service. See cause >> for the exact endpoint that is failing to resolve. If this is happening on >> an endpoint that previously worked, there may be a network connectivity >> issue or your DNS cache could be storing endpoints for too long. >> at >> app//software.amazon.awssdk.core.exception.SdkClientException$BuilderImpl.build(SdkClientException.java:111) >> at >> app//software.amazon.awssdk.awscore.interceptor.HelpfulUnknownHostExceptionInterceptor.modifyException(HelpfulUnknownHostExceptionInterceptor.java:59) >> at >> app//software.amazon.awssdk.core.interceptor.ExecutionInterceptorChain.modifyException(ExecutionInterceptorChain.java:202) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.utils.ExceptionReportingUtils.runModifyException(ExceptionReportingUtils.java:54) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.utils.ExceptionReportingUtils.reportFailureToInterceptors(ExceptionReportingUtils.java:38) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.ExecutionFailureExceptionReportingStage.execute(ExecutionFailureExceptionReportingStage.java:39) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.ExecutionFailureExceptionReportingStage.execute(ExecutionFailureExceptionReportingStage.java:26) >> at >> app//software.amazon.awssdk.core.internal.http.AmazonSyncHttpClient$RequestExecutionBuilderImpl.execute(AmazonSyncHttpClient.java:193) >> at >> app//software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.invoke(BaseSyncClientHandler.java:103) >> at >> app//software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.doExecute(BaseSyncClientHandler.java:171) >> at >> app//software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.lambda$execute$1(BaseSyncClientHandler.java:82) >> at >> app//software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.measureApiCallSuccess(BaseSyncClientHandler.java:179) >> at >> app//software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.execute(BaseSyncClientHandler.java:76) >> at >> app//software.amazon.awssdk.core.client.handler.SdkSyncClientHandler.execute(SdkSyncClientHandler.java:45) >> at >> app//software.amazon.awssdk.awscore.client.handler.AwsSyncClientHandler.execute(AwsSyncClientHandler.java:56) >> at >> app//software.amazon.awssdk.services.s3.DefaultS3Client.createBucket(DefaultS3Client.java:1149) >> at >> app//org.apache.iceberg.aws.s3.signer.TestS3RestSigner.before(TestS3RestSigner.java:141) >> >> Caused by: >> software.amazon.awssdk.core.exception.SdkClientException: Unable >> to execute HTTP request: iceberg-s3-signer-test.localhost >> at >> app//software.amazon.awssdk.core.exception.SdkClientException$BuilderImpl.build(SdkClientException.java:111) >> at >> app//software.amazon.awssdk.core.exception.SdkClientException.create(SdkClientException.java:47) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.utils.RetryableStageHelper.setLastException(RetryableStageHelper.java:223) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.RetryableStage.execute(RetryableStage.java:83) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.RetryableStage.execute(RetryableStage.java:36) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.RequestPipelineBuilder$ComposingRequestPipelineStage.execute(RequestPipelineBuilder.java:206) >> at >> app//software.amazon.awssdk.core.internal.http.StreamManagingStage.execute(StreamManagingStage.java:56) >> at >> app//software.amazon.awssdk.core.internal.http.StreamManagingStage.execute(StreamManagingStage.java:36) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallTimeoutTrackingStage.executeWithTimer(ApiCallTimeoutTrackingStage.java:80) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallTimeoutTrackingStage.execute(ApiCallTimeoutTrackingStage.java:60) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallTimeoutTrackingStage.execute(ApiCallTimeoutTrackingStage.java:42) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallMetricCollectionStage.execute(ApiCallMetricCollectionStage.java:48) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallMetricCollectionStage.execute(ApiCallMetricCollectionStage.java:31) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.RequestPipelineBuilder$ComposingRequestPipelineStage.execute(RequestPipelineBuilder.java:206) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.RequestPipelineBuilder$ComposingRequestPipelineStage.execute(RequestPipelineBuilder.java:206) >> at >> app//software.amazon.awssdk.core.internal.http.pipeline.stages.ExecutionFailureExceptionReportingStage.execute(ExecutionFailureExceptionReportingStage.java:37) >> ... 11 more >> >> Caused by: >> java.net.UnknownHostException: >> iceberg-s3-signer-test.localhost >> at >> java.base/java.net.InetAddress$CachedAddresses.get(InetAddress.java:797) >> at >> java.base/java.net.InetAddress.getAllByName0(InetAddress.java:1519) >> at >> java.base/java.net.InetAddress.getAllByName(InetAddress.java:1378) >> at >> java.base/java.net.InetAddress.getAllByName(InetAddress.java:1306) >> at >> org.apache.http.impl.conn.SystemDefaultDnsResolver.resolve(SystemDefaultDnsResolver.java:45) >> at >> org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:112) >> at >> org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:376) >> at >> software.amazon.awssdk.http.apache.internal.conn.ClientConnectionManagerFactory$DelegatingHttpClientConnectionManager.connect(ClientConnectionManagerFactory.java:86) >> at >> org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:393) >> at >> org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:236) >> at >> org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186) >> at >> org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185) >> at >> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83) >> at >> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56) >> at >> software.amazon.awssdk.http.apache.internal.impl.ApacheSdkHttpClient.execute(ApacheSdkHttpClient.java:72) >> at >> software.amazon.awssdk.http.apache.ApacheHttpClient.execute(ApacheHttpClient.java:254) >> at >> software.amazon.awssdk.http.apache.ApacheHttpClient.access$500(ApacheHttpClient.java:104) >> at >> software.amazon.awssdk.http.apache.ApacheHttpClient$1.call(ApacheHttpClient.java:231) >> at >> software.amazon.awssdk.http.apache.ApacheHttpClient$1.call(ApacheHttpClient.java:228) >> at >> software.amazon.awssdk.core.internal.util.MetricUtils.measureDurationUnsafe(MetricUtils.java:63) >> at >> software.amazon.awssdk.core.internal.http.pipeline.stages.MakeHttpRequestStage.executeHttpRequest(MakeHttpRequestStage.java:77) >> at >> software.amazon.awssdk.core.internal.http.pipeline.stages.MakeHttpRequestStage.execute(MakeHttpRequestStage.java:56) >> at >> software.amazon.awssdk.core.internal.http.pipeline.stages.MakeHttpRequestStage.execute(MakeHttpRequestStage.java:39) >> at >> software.amazon.awssdk.core.internal.http.pipeline.RequestPipelineBuilder$ComposingRequestPipelineStage.execute(RequestPipelineBuilder.java:206) >> at >> software.amazon.awssdk.core.internal.http.pipeline.RequestPipelineBuilder$ComposingRequestPipelineStage.execute(RequestPipelineBuilder.java:206) >> at >> software.amazon.awssdk.core.internal.http.pipeline.RequestPipelineBuilder$ComposingRequestPipelineStage.execute(RequestPipelineBuilder.java:206) >> at >> software.amazon.awssdk.core.internal.http.pipeline.RequestPipelineBuilder$ComposingRequestPipelineStage.execute(RequestPipelineBuilder.java:206) >> at >> software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallAttemptTimeoutTrackingStage.execute(ApiCallAttemptTimeoutTrackingStage.java:73) >> at >> software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallAttemptTimeoutTrackingStage.execute(ApiCallAttemptTimeoutTrackingStage.java:42) >> at >> software.amazon.awssdk.core.internal.http.pipeline.stages.TimeoutExceptionHandlingStage.execute(TimeoutExceptionHandlingStage.java:78) >> at >> software.amazon.awssdk.core.internal.http.pipeline.stages.TimeoutExceptionHandlingStage.execute(TimeoutExceptionHandlingStage.java:40) >> at >> software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallAttemptMetricCollectionStage.execute(ApiCallAttemptMetricCollectionStage.java:50) >> at >> software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallAttemptMetricCollectionStage.execute(ApiCallAttemptMetricCollectionStage.java:36) >> at >> software.amazon.awssdk.core.internal.http.pipeline.stages.RetryableStage.execute(RetryableStage.java:81) >> ... 23 more >> >> Best, >> >> Yufei >> >> >> On Sun, Jul 23, 2023 at 9:01 PM Daniel Weeks <dwe...@apache.org> wrote: >> >>> +1 (binding) >>> >>> Validated license/sigs/sums/build/test. >>> >>> (Had the same problem with some of the S3 containerized tests as 1.3.0) >>> >>> -Dan >>> >>> On Wed, Jul 19, 2023 at 9:29 AM Eduard Tudenhoefner <edu...@tabular.io> >>> wrote: >>> >>>> +1 (non-binding) >>>> >>>> * validated checksum and signature >>>> * checked license docs & ran RAT checks >>>> * ran build and tests with JDK11 >>>> * built new docker images and ran through >>>> https://iceberg.apache.org/spark-quickstart/ >>>> <https://iceberg.apache.org/spark-quickstart/> >>>> >>>> One thing I noticed is that some tests don't work when running the >>>> build with *JDK17* (e.g. running *./gradlew build >>>> :iceberg-flink:iceberg-flink-runtime-1.17:integrationTest -x test* >>>> fails). This is not related to this release, but I just wanted to mention >>>> this in case anyone else runs into this. >>>> >>>> >>>> Eduard >>>> >>>> On Mon, Jul 17, 2023 at 8:01 PM Szehon Ho <szehon.apa...@gmail.com> >>>> wrote: >>>> >>>>> Hi Everyone, >>>>> >>>>> I propose that we release the following RC as the official Apache >>>>> Iceberg 1.3.1 release. >>>>> >>>>> The commit ID is 62c34711c3f22e520db65c51255512f6cfe622c4 >>>>> * This corresponds to the tag: apache-iceberg-1.3.1-rc1 >>>>> * https://github.com/apache/iceberg/commits/apache-iceberg-1.3.1-rc1 >>>>> * >>>>> https://github.com/apache/iceberg/tree/62c34711c3f22e520db65c51255512f6cfe622c4 >>>>> >>>>> The release tarball, signature, and checksums are here: >>>>> * >>>>> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.3.1-rc1 >>>>> >>>>> You can find the KEYS file here: >>>>> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>>> >>>>> Convenience binary artifacts are staged on Nexus. The Maven repository >>>>> URL is: >>>>> * >>>>> https://repository.apache.org/content/repositories/orgapacheiceberg-1141/ >>>>> >>>>> This release includes several important bug fixes over 1.3.0, >>>>> including: >>>>> * Fix Spark RewritePositionDeleteFiles failure for certain partition >>>>> types (#8059) >>>>> * Fix Spark RewriteDataFiles concurrency edge-case on commit timeouts >>>>> (#7933) >>>>> * Table Metadata parser now accepts null current-snapshot-id, >>>>> properties, snapshots fields (#8064) >>>>> * FlinkCatalog creation no longer creates the default database (#8039) >>>>> * Fix loading certain V1 table branch snapshots using snapshot >>>>> references (#7621) >>>>> * Fix Spark partition-level DELETE operations for WAP branches (#7900) >>>>> * Fix HiveCatalog deleting metadata on failures in checking lock >>>>> status (#7931) >>>>> >>>>> Please download, verify, and test. >>>>> >>>>> Please vote in the next 72 hours. (Weekends excluded) >>>>> >>>>> [ ] +1 Release this as Apache Iceberg 1.3.1 >>>>> [ ] +0 >>>>> [ ] -1 Do not release this because... >>>>> >>>>> Only PMC members have binding votes, but other community members are >>>>> encouraged to cast >>>>> non-binding votes. This vote will pass if there are 3 binding +1 votes >>>>> and more binding >>>>> +1 votes than -1 votes. >>>>> >>>>> Thanks >>>>> Szehon >>>>> >>>> > > -- > Ryan Blue > Tabular >
