+1 (non-binding) - validated checksum and signature - checked license docs & ran RAT checks - ran build and tests with JDK11 - tested with Trino to make sure #7235 <https://github.com/apache/iceberg/pull/7235> is fixed - tested remote signing with/without a local AWS config to make sure issues we saw earlier are fixed - verified that previous metadata locations are correct when using *snapshot-loading-mode=refs* - built new docker images and ran through https://iceberg.apache.org/spark-quickstart/
Just FYI that the flakiness in HadoopFileIOTest has been fixed on master, so we shouldn't be seeing any issues due to parallel testing. Thanks Dan for driving this release. Eduard On Mon, Apr 10, 2023 at 11:00 PM Ryan Blue <b...@tabular.io> wrote: > +1 (binding) > > Checked signature, checksum, licenses, built the project in Java 8 > > On Mon, Apr 10, 2023 at 1:58 PM Daniel Weeks <dwe...@apache.org> wrote: > >> +1 (binding) >> >> Verified sigs/sums/build/test >> Also ran through some local testing with Java 17 >> >> I ran into the HadoopFileIOTest flakiness, but that seemed to be fixed by >> turning off parallel runs. >> >> -Dan >> >> On Fri, Apr 7, 2023 at 4:44 PM Yufei Gu <flyrain...@gmail.com> wrote: >> >>> +1 (binding) >>> >>> Verified signature, checksum >>> Verified License >>> Built and ran tests >>> Ran queries on Spark 3.3_2.12 >>> >>> >>> Best, >>> >>> Yufei >>> >>> `This is not a contribution` >>> >>> >>> On Thu, Apr 6, 2023 at 11:33 PM Szehon Ho <szehon.apa...@gmail.com> >>> wrote: >>> >>>> +1 (non-binding) >>>> >>>> Verified signature >>>> Verified checksum >>>> Verified License >>>> Built and ran tests >>>> Ran simple queries on spark 3.3. >>>> >>>> Thanks Dan for the release, >>>> Szehon >>>> >>>> On Thu, Apr 6, 2023 at 12:04 PM Daniel Weeks <dwe...@apache.org> wrote: >>>> >>>>> Hi Everyone, >>>>> >>>>> I propose that we release the following RC as the official Apache >>>>> Iceberg 1.2.1 release. >>>>> >>>>> The commit ID is 4e2cdccd7453603af42a090fc5530f2bd20cf1be >>>>> * This corresponds to the tag: apache-iceberg-1.2.1-rc2 >>>>> * https://github.com/apache/iceberg/commits/apache-iceberg-1.2.1-rc2 >>>>> * >>>>> https://github.com/apache/iceberg/tree/4e2cdccd7453603af42a090fc5530f2bd20cf1be >>>>> >>>>> The release tarball, signature, and checksums are here: >>>>> * >>>>> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.2.1-rc2 >>>>> >>>>> You can find the KEYS file here: >>>>> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>>> >>>>> Convenience binary artifacts are staged on Nexus. The Maven repository >>>>> URL is: >>>>> * >>>>> https://repository.apache.org/content/repositories/orgapacheiceberg-1131/ >>>>> >>>>> Please download, verify, and test. >>>>> >>>>> Please vote in the next 72 hours. >>>>> >>>>> [ ] +1 Release this as Apache Iceberg 1.2.1 >>>>> [ ] +0 >>>>> [ ] -1 Do not release this because... >>>>> >>>> > > -- > Ryan Blue > Tabular >
