Switching to HadoopTables wouldn't hurt, although if you're having trouble with TestTables, then it could easily be that the state of the helper is being cleared. I think you're probably better off trying to figure out why the table is missing or was deleted, rather than switching.
On Fri, Feb 24, 2023 at 2:55 AM Tamas Sule <tamas.s...@cloudera.com.invalid> wrote: > Hi Ryan, > > Thanks for the reply. I'm working on some new features in the Flink > connector > and the changes caused a lot of tests to fail (for example > in TestDeltaTaskWriter) > because these test classes use TestTables. As you said that this is an > internal > helper class, I assume the Flink connector should not rely on it at all. > Some other > tests use HadoopTables in Flink, which work fine. Would it be the correct > approach > to refactor the failing Flink test to use tables created using > HadoopTables? > > Thanks, > Tamas > > On 2023/02/23 19:38:17 Ryan Blue wrote: > > Tamas, > > > > What are you trying to do? TestTables is intended to be an internal > helper > > class that manages some tables in memory and shouldn't actually be used > > outside of Iceberg or the tests that currently rely on it. > > > > Ryan > > > > On Thu, Feb 23, 2023 at 8:55 AM Tamas Sule <ta...@cloudera.com.invalid> > > wrote: > > > > > Hello, I’m having trouble working with the TestTables class: I’m > writing a > > > test which hits a code path that uses IcebergGenerics.read, which fails > > > with the following error: Cannot load metadata: metadata file location > is > > > null. Looking at the TestTableOperations class, it doesn’t actually > write > > > out the metadata json to the filesystem but rather keeps it in memory. > Is > > > this a shortcoming of these test classes at the moment, or am I > supposed to > > > use something else to test this? Thanks! > > > > > > > > > -- > > Ryan Blue > > Tabular > > > -- Ryan Blue Tabular
