+1 (binding) * Verified licenses, checksum, and signature * Built and tested with JDK 11
On Fri, Nov 25, 2022 at 11:17 AM Jahagirdar, Amogh <jaham...@amazon.com.invalid> wrote: > +1 non-binding > > 1. Verified checksum and signature > 2. Verified license docs and ran RAT checks > 3. Verified build and all tests passed with JDK11 > > Thanks, > > Amogh Jahagirdar > > > > *From: *Mingliang Liu <lium...@apache.org> > *Reply-To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org> > *Date: *Thursday, November 24, 2022 at 11:12 PM > *To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org> > *Cc: *John Zhuge <jzh...@apache.org> > *Subject: *RE: [EXTERNAL][VOTE] Release Apache Iceberg 1.1.0 RC4 > > > > *CAUTION*: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > > Happy holidays! > > +1 (non-binding) > > 1. Check out to apache-iceberg-1.1.0-rc4 tag in source code repo, and > build locally > 2. Download the release tarball and check RAT license, GPG signature > and SHA checksum > 3. Untar the release tarball and build locally (skip tests) > 4. Download release artifact iceberg-spark-runtime-3.3_2.12-1.1.0.jar and > use it to query an Iceberg table with various data types via Spark shell > 5. Use artifact built from our internal Iceberg branch by John (see > his voting) and run internal Flink integration tests (we don't use > :iceberg-flink) > > All good. Test env is Java 8 + M1 macOS. > > > > Thanks, > > > > On Thu, Nov 24, 2022 at 1:49 PM John Zhuge <jzh...@apache.org> wrote: > > Happy holidays! > > +1 (non-binding) > > > > Verified signature, checksum, and license, > > Built and tested with Java 8. > > > > Some unit test failures but don't feel they should block the release: > > - :iceberg-flink:iceberg-flink-runtime-1.16:integrationTest > - :iceberg-flink:iceberg-flink-1.16:test > - :iceberg-mr:test > > > Rebased our internal Iceberg branch and integrated with our internal Spark > 3.3 branch. Passed integration tests. > > > > On Thu, Nov 24, 2022 at 1:07 AM Driesprong, Fokko <fo...@apache.org> > wrote: > > Hey everyone! > > > > First of all, happy thanksgiving! > > > > +1 (non-binding) > > > > It looks good now on the Trino side. Still some tests are failing > <https://github.com/trinodb/trino/pull/15079>, but that's explainable. As > an example, the following test is still failing: > https://github.com/trinodb/trino/blob/ed2f14ce92a67fd5c951d6258a2d1e9d4540d546/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMetadataFileOperations.java#L229-L241 > > > > With the output: > > > > Expecting: > <[FileOperation{fileType=SNAPSHOT, operationType=INPUT_FILE_GET_LENGTH}, > FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_GET_LENGTH}, > FileOperation{fileType=SNAPSHOT, operationType=INPUT_FILE_NEW_STREAM}, > FileOperation{fileType=METADATA_JSON, > operationType=INPUT_FILE_NEW_STREAM}, > FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_NEW_STREAM}]> > to contain exactly in any order: > <[FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_GET_LENGTH}, > FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_GET_LENGTH}, > FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_NEW_STREAM}, > FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_NEW_STREAM}, > FileOperation{fileType=METADATA_JSON, > operationType=INPUT_FILE_NEW_STREAM}, > FileOperation{fileType=SNAPSHOT, operationType=INPUT_FILE_GET_LENGTH}, > FileOperation{fileType=SNAPSHOT, operationType=INPUT_FILE_NEW_STREAM}]> > but could not find the following elements: > <[FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_GET_LENGTH}, > FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_NEW_STREAM}]> > > > > It looks like we're reading fewer manifests. After running a git bisect, I > narrowed it down to this PR: https://github.com/apache/iceberg/pull/5632, > which is an optimization that makes perfect sense. > > > > Kind regards, > > Fokko Driesprong > > > > > > Op wo 23 nov. 2022 om 17:15 schreef Eduard Tudenhoefner <edu...@tabular.io > >: > > +1 (non-binding) > > · validated checksum and signature > > · checked license docs & ran RAT checks > > · ran build and tests with JDK11 > > · integrated 1.1.0 RC4 into Presto > <https://github.com/prestodb/presto/pull/18709> > > > > > > On Wed, Nov 23, 2022 at 9:14 AM Ajantha Bhat <ajanthab...@gmail.com> > wrote: > > +1 (non-binding) > > - verified tests against spark-3.3 runtime jar with Nessie catalog. > - verified the contents of the iceberg-spark-runtime-3.3_2.12-1.1.0.jar > - checked for spark-3.0 removal > - validated checksum and signature > - checked license docs & ran RAT checks > - ran build with JDK1.8 > > Thanks, > Ajantha > > > > On Tue, Nov 22, 2022 at 9:49 PM Gabor Kaszab <gaborkas...@apache.org> > wrote: > > Hi Everyone, > > > > I propose that we release the following RC as the official Apache Iceberg > 1.1.0 release. > > > > The commit ID is ede085d0f7529f24acd0c81dd0a43f7bb969b763 > > * This corresponds to the tag: apache-iceberg-1.1.0-rc4 > > * https://github.com/apache/iceberg/commits/apache-iceberg-1.1.0-rc4 > > * > https://github.com/apache/iceberg/tree/ede085d0f7529f24acd0c81dd0a43f7bb969b763 > > > > The release tarball, signature, and checksums are here: > > * https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.1.0-rc4 > > > > You can find the KEYS file here: > > * https://dist.apache.org/repos/dist/dev/iceberg/KEYS > > > > Convenience binary artifacts are staged on Nexus. The Maven repository URL is: > > * https://repository.apache.org/content/repositories/orgapacheiceberg-1114/ > > > > Please download, verify, and test. > > > > Please vote in the next 72 hours. > > > > [ ] +1 Release this as Apache Iceberg 1.1.0 > > [ ] +0 > > [ ] -1 Do not release this because... > > > > > -- > > John Zhuge > > -- Ryan Blue Tabular
