+1 [non-binding] Thank you Piotr for all of the work you’ve put into this.
This should greatly benefit not only Iceberg on Trino, but hopefully can be used in many novel ways due to its well thought out generic design and incorporation of the ability to extend with new sketches. Looking forward to the improvements this will bring. - Kyle On Fri, Jun 10, 2022 at 1:47 PM Alexander Jo <alex...@starburstdata.com> wrote: > +1, let's do it! > > On Fri, Jun 10, 2022 at 2:47 PM John Zhuge <jzh...@apache.org> wrote: > >> +1 Looking forward to the features it enables. >> >> On Fri, Jun 10, 2022 at 10:11 AM Yufei Gu <flyrain...@gmail.com> wrote: >> >>> +1. Looking forward to the partition stats. >>> Best, >>> >>> Yufei >>> >>> >>> On Thu, Jun 9, 2022 at 6:32 PM Daniel Weeks <dwe...@apache.org> wrote: >>> >>>> +1 as well. Excited about the progress here. >>>> >>>> -Dan >>>> >>>> On Thu, Jun 9, 2022, 6:25 PM Junjie Chen <chenjunjied...@gmail.com> >>>> wrote: >>>> >>>>> +1, really nice! Indexes are coming! >>>>> >>>>> On Fri, Jun 10, 2022 at 8:04 AM Szehon Ho <szehon.apa...@gmail.com> >>>>> wrote: >>>>> >>>>>> +1, it's an exciting step for Iceberg, look forward to all the new >>>>>> statistics and secondary indices it will allow. >>>>>> >>>>>> Had a few questions of what the reference to Puffin file(s) will be >>>>>> in the Iceberg spec, but it's orthogonal to Puffin file format itself. >>>>>> >>>>>> Thanks, >>>>>> Szehon >>>>>> >>>>>> On Thu, Jun 9, 2022 at 3:32 PM Ryan Blue <b...@tabular.io> wrote: >>>>>> >>>>>>> +1 from me! >>>>>>> >>>>>>> There may also be people that haven't followed the design >>>>>>> discussions and we can start a DISCUSS thread if needed. But if >>>>>>> everyone is >>>>>>> comfortable with the design and implementation, I think it's ready for a >>>>>>> vote as well. >>>>>>> >>>>>>> Huge thanks to Piotr for getting this ready! I think the format is >>>>>>> going to be really useful for both stats and indexes in Iceberg. >>>>>>> >>>>>>> On Thu, Jun 9, 2022 at 3:35 AM Piotr Findeisen < >>>>>>> pi...@starburstdata.com> wrote: >>>>>>> >>>>>>>> Hi Everyone, >>>>>>>> >>>>>>>> I propose that we adopt Puffin file format as a file format for >>>>>>>> statistics and indexes in Iceberg tables. >>>>>>>> >>>>>>>> Puffin file format specification: >>>>>>>> https://github.com/apache/iceberg/blob/master/format/puffin-spec.md >>>>>>>> (previous discussions: https://github.com/apache/iceberg/pull/4944 >>>>>>>> , https://github.com/apache/iceberg-docs/pull/69) >>>>>>>> >>>>>>>> Intend use: >>>>>>>> * statistics in Iceberg tables (see >>>>>>>> https://github.com/apache/iceberg/pull/4945 and associated >>>>>>>> proposed implementation https://github.com/apache/iceberg/pull/4741 >>>>>>>> ) >>>>>>>> * in the future: storage for secondary indexes >>>>>>>> >>>>>>>> Puffin file reader and writer implementation: >>>>>>>> https://github.com/apache/iceberg/pull/4537 >>>>>>>> >>>>>>>> Thanks, >>>>>>>> PF >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Ryan Blue >>>>>>> Tabular >>>>>>> >>>>>> >>>>> >>>>> -- >>>>> Best Regards >>>>> >>>> >> >> -- >> John Zhuge >> >
