felixYyu commented on code in PR #4438:
URL: https://github.com/apache/iceberg/pull/4438#discussion_r841437117


##########
hive3/src/main/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java:
##########
@@ -191,12 +191,12 @@ public boolean hasFooter() {
   }
 
   /**
-   * @return {@code true} if file schema doesn't have Acid metadata columns
    * Such file may be in a delta_x_y/ or base_x due to being added via
    * "load data" command.  It could be at partition|table root due to table 
having
    * been converted from non-acid to acid table.  It could even be something 
like
    * "warehouse/t/HIVE_UNION_SUBDIR_15/000000_0" if it was written by an
    * "insert into t select ... from A union all select ... from B"
+   * @return {@code true} if file schema doesn't have Acid metadata columns

Review Comment:
   thanks, I got it and tried to description it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to