+1 (binding)
- Ran RAT checks
- Validated checksum and signature
- Built and tested
- Ran simple tests with Spark 3.0.1 and a local FS catalog
I also hit a strange issue that may be a flaky test. During testing,
TestHiveIcebergStorageHandlerWithEngine.testInsertSupportedTypes failed in
all 6 configurations with MR. Looks like a time zone issue because the
value was off by 8 hours and I’m in UTC-8. This didn’t happen when I ran
the suite again and it doesn’t look like anyone else has hit it. My guess
is that it’s some test issue where Hive interacts with the JVM-global time
zone or something.
org.apache.iceberg.mr.hive.TestHiveIcebergStorageHandlerWithEngine >
testInsertSupportedTypes[fileFormat=PARQUET, engine=mr,
catalog=CUSTOM_CATALOG] FAILED
java.lang.AssertionError: expected:<1992-02-26T11:20:57.391728Z>
but was:<1992-02-26T19:20:57.391728Z>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.iceberg.mr.hive.HiveIcebergTestUtils.assertEquals(HiveIcebergTestUtils.java:202)
at
org.apache.iceberg.mr.hive.HiveIcebergTestUtils.validateData(HiveIcebergTestUtils.java:245)
at
org.apache.iceberg.mr.hive.HiveIcebergTestUtils.validateData(HiveIcebergTestUtils.java:228)
at
org.apache.iceberg.mr.hive.TestHiveIcebergStorageHandlerWithEngine.testInsertSupportedTypes(TestHiveIcebergStorageHandlerWithEngine.java:326)
Since this passes for everyone else, Hive is experimental, and it passed
when I re-ran, I don’t think it’s a blocker.
On Wed, Mar 31, 2021 at 6:22 PM Yufei Gu <flyrain...@gmail.com> wrote:
> +1 (non-binding)
>
> 1. ran RAT checks.
> 2. build and test.
>
> Best,
>
> Yufei
>
> `This is not a contribution`
>
>
> On Wed, Mar 31, 2021 at 10:22 AM Carl Steinbach <c...@apache.org> wrote:
>
>> +1 (binding)
>>
>> + Built and tested code following instructions in README
>> + Verified checksums
>>
>> - Carl
>>
>> On Wed, Mar 31, 2021 at 1:13 PM John Zhuge <jzh...@apache.org> wrote:
>>
>>> 1 (non-binding)
>>>
>>> Checked signature, checksum, and license.
>>> Ran build and test.
>>>
>>> On Wed, Mar 31, 2021 at 5:00 AM Peter Vary <pv...@cloudera.com.invalid>
>>> wrote:
>>>
>>>> +1
>>>> Checked the signatures
>>>> Run build and tests
>>>>
>>>> Sadly did not have time to run manual Hive tests this time and I will
>>>> be out till mid next week. :(
>>>>
>>>> Thanks,
>>>> Peter
>>>>
>>>> On Mar 30, 2021, at 23:41, Russell Spitzer <russell.spit...@gmail.com>
>>>> wrote:
>>>>
>>>> +1 -
>>>> Ran the tests
>>>> Checked the Checksum
>>>> Made sure there were no binary files anywhere in the source release
>>>> (there is drama going on elsewhere about this)
>>>>
>>>> On Tue, Mar 30, 2021 at 3:55 PM Edgar Rodriguez <
>>>> edgar.rodrig...@airbnb.com.invalid> wrote:
>>>>
>>>>> +1 (non-binding)
>>>>>
>>>>> - Verified build, signature and checkum.
>>>>> - Ran internal integration tests.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> On Tue, Mar 30, 2021 at 7:50 AM Ryan Murray <rym...@gmail.com> wrote:
>>>>>
>>>>>> +1 (non-binding)
>>>>>>
>>>>>> verified build, tests, signature, checksum.
>>>>>>
>>>>>> Best,
>>>>>> Ryan
>>>>>>
>>>>>> On Tue, Mar 30, 2021 at 4:40 AM Jack Ye <yezhao...@gmail.com> wrote:
>>>>>>
>>>>>>> +1 (non-binding)
>>>>>>>
>>>>>>> Verified build, unit test, AWS integration test, signature, checksum.
>>>>>>> Verified fix of #2146, #2267, #2333 in AWS EMR Spark3 environment.
>>>>>>>
>>>>>>> Best,
>>>>>>> Jack Ye
>>>>>>>
>>>>>>> On Mon, Mar 29, 2021 at 5:58 PM Anton Okolnychyi <
>>>>>>> aokolnyc...@apple.com.invalid> wrote:
>>>>>>>
>>>>>>>> +1 (binding)
>>>>>>>>
>>>>>>>> Checked the signature and checksum, ran RAT checks and tests.
>>>>>>>>
>>>>>>>> Had to trigger tests twice due to a HMS related failure in DELETE
>>>>>>>> tests in Spark extensions. We have noticed that problem while testing
>>>>>>>> 0.11.0 RCs and it was fixed in a later commit, which is not part of
>>>>>>>> 0.11.1.
>>>>>>>>
>>>>>>>>
>>>>>>>> https://github.com/apache/iceberg/commit/19622dcfcb426485748fa017a6181e23df5732dc
>>>>>>>>
>>>>>>>> - Anton
>>>>>>>>
>>>>>>>> On 29 Mar 2021, at 17:42, Anton Okolnychyi <
>>>>>>>> aokolnyc...@apple.com.INVALID> wrote:
>>>>>>>>
>>>>>>>> Here is the link to steps we normally use to validate a release
>>>>>>>> candidate:
>>>>>>>>
>>>>>>>> https://lists.apache.org/thread.html/rd5e6b1656ac80252a9a7d473b36b6227da91d07d86d4ba4bee10df66%40%3Cdev.iceberg.apache.org%3E
>>>>>>>> <https://lists.apache.org/thread.html/rd5e6b1656ac80252a9a7d473b36b6227da91d07d86d4ba4bee10df66@%3Cdev.iceberg.apache.org%3E>
>>>>>>>>
>>>>>>>> - Anton
>>>>>>>>
>>>>>>>> On 29 Mar 2021, at 17:41, Anton Okolnychyi <
>>>>>>>> aokolnyc...@apple.com.INVALID> wrote:
>>>>>>>>
>>>>>>>> Hi everyone,
>>>>>>>>
>>>>>>>> I propose the following RC to be released as official Apache
>>>>>>>> Iceberg 0.11.1 release.
>>>>>>>>
>>>>>>>> The commit id is 29cf712a821aa937e176f2d79a5593c4a1429e7f
>>>>>>>> * This corresponds to the tag: apache-iceberg-0.11.1-rc0
>>>>>>>> *
>>>>>>>> https://github.com/apache/iceberg/commits/apache-iceberg-0.11.1-rc0
>>>>>>>> *
>>>>>>>> https://github.com/apache/iceberg/tree/29cf712a821aa937e176f2d79a5593c4a1429e7f
>>>>>>>>
>>>>>>>> The release tarball, signature, and checksums are here:
>>>>>>>> *
>>>>>>>> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-0.11.1-rc0/
>>>>>>>>
>>>>>>>> You can find the KEYS file here (make sure to import the new key
>>>>>>>> that was used to sign the release):
>>>>>>>> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS
>>>>>>>>
>>>>>>>> Convenience binary artifacts are staged in Nexus. The Maven
>>>>>>>> repository URL is:
>>>>>>>> *
>>>>>>>> https://repository.apache.org/content/repositories/orgapacheiceberg-1016/
>>>>>>>>
>>>>>>>> This patch release includes these fixes:
>>>>>>>> https://github.com/apache/iceberg/milestone/13?closed=1
>>>>>>>>
>>>>>>>> Please download, verify, and test.
>>>>>>>>
>>>>>>>> Please vote in the next 72 hours.
>>>>>>>>
>>>>>>>> [ ] +1 Release this as Apache Iceberg 0.11.1
>>>>>>>> [ ] +0
>>>>>>>> [ ] -1 Do not release this because…
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Anton
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>
>>>>> --
>>>>> Edgar R
>>>>>
>>>>
>>>>
>>>
>>> --
>>> John Zhuge
>>>
>>
--
Ryan Blue
Software Engineer
Netflix
